Page MenuHomePhabricator
Create Task
Maniphest T313686

Clicking "Add link" on a selected work has UX issues
Open, LowPublic
Actions

Description

  1. Select a word you want to link
  2. Observe in the sidebar the "+ Add link" button
  3. First issue: the title is incorrectly aligned

image.png (187×384 px, 22 KB)

  1. Click the "+ Add link" button
  2. Second issue: The word is linked but the surface is immediately blurred, losing your place in the document. The sidebar goes back to showing the issues card, so there is no confirmation of your action.
  3. Click on the link to focus it again.
  4. Third issue: An empty link inspector is shown in the sidebar:

image.png (66×379 px, 2 KB)

Details

SubjectRepoBranchLines +/-
Fix empty rendering of new CXLinkContextItem'smediawiki/extensions/ContentTranslationmaster+13 -4
Fix selection of new link in TextSelectionContextItemmediawiki/extensions/ContentTranslationmaster+7 -5
Fix inheritance of CXTextSelectionContextItemmediawiki/extensions/ContentTranslationmaster+2 -2
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 24 2022, 12:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2022, 12:59 PM
Nikerabbit triaged this task as Low priority.Aug 1 2022, 11:13 AM
Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.
gerritbot added a comment.Aug 1 2022, 2:57 PM

Change 819094 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/ContentTranslation@master] Fix inheritance of CXTextSelectionContextItem

https://gerrit.wikimedia.org/r/819094

gerritbot added a project: Patch-For-Review.Aug 1 2022, 2:57 PM
gerritbot added a comment.Aug 1 2022, 3:41 PM

Change 819105 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/ContentTranslation@master] Fix selection of new link in TextSelectionContextItem

https://gerrit.wikimedia.org/r/819105

gerritbot added a comment.Aug 1 2022, 3:42 PM

Change 819106 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/ContentTranslation@master] Fix empty rendering of new CXLinkContextItem's

https://gerrit.wikimedia.org/r/819106

Esanders added a comment.Aug 1 2022, 3:43 PM

The above three patches fix the three issues in the description respectively.

• santhosh added projects: Language-Team (Language-2022-July-September), Unplanned-Sprint-Work.Aug 2 2022, 5:21 AM
• santhosh subscribed.

@Esanders Thanks for catching this issues and giving fixes.

gerritbot added a comment.Aug 2 2022, 5:55 AM

Change 819094 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix inheritance of CXTextSelectionContextItem

https://gerrit.wikimedia.org/r/819094

gerritbot added a comment.Aug 2 2022, 5:58 AM

Change 819105 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix selection of new link in TextSelectionContextItem

https://gerrit.wikimedia.org/r/819105

gerritbot added a comment.Aug 2 2022, 5:58 AM

Change 819106 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix empty rendering of new CXLinkContextItem's

https://gerrit.wikimedia.org/r/819106

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 2 2022, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2022, 6:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL