Page MenuHomePhabricator
Create Task
Maniphest T314064

Add license info and anonymous edit warning to the no-JS version of Special:NewLexemeAlpha
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As a user creating lexemes without JavaScript enabled, I want to have the same information available to me as users of the JS version.

Problem:
The no-JS version of Special:NewLexemeAlpha currently doesn’t show license information (shown right above the submit button in the JS version) nor an anonymous edit warning (added beneath the search link in T313466).

Example:

Screenshots/mockups:

image.png (963×1 px, 255 KB)

BDD
GIVEN JavaScript is disabled
WHEN loading Special:NewLexemeAlpha
THEN license information is shown above the "Create Lexeme" button

GIVEN JavaScript is disabled
AND the user is not logged in
WHEN loading Special:NewLexemeAlpha
THEN a message about the IP address being tracked, as well as login/signup links, are shown after the intro paragraph

Acceptance criteria:

  • license information is shown
  • an anonymous edit warning is shown for anonymous users

Details

SubjectRepoBranchLines +/-
Add anonymous edit warning in no javascript modemediawiki/extensions/WikibaseLexememaster+40 -2
Add copyright message for nojsmediawiki/extensions/WikibaseLexememaster+35 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 28 2022, 3:48 PM
Lydia_Pintscher added a project: Wikidata Dev Team.Jul 29 2022, 2:40 PM
Lydia_Pintscher moved this task from Backlog to Feedback from testing after release on the Special:NewLexeme revival board.
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.
Lydia_Pintscher updated the task description. (Show Details)Aug 3 2022, 8:35 AM
karapayneWMDE set the point value for this task to 5.Aug 9 2022, 8:57 AM
karapayneWMDE moved this task from Product Backlog to Sprint-∞ on the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Aug 10 2022, 10:42 AM
ItamarWMDE subscribed.EditedAug 10 2022, 1:01 PM

Task Breakdown Notes

  • The copyright text should be displayed above the submit button, the same as the JS version of this message.
  • Code duplication is allowed, as w are already utilizing it to display the current NoJS page
  • This change is to be done in SpecialNewLexemeAlpha.php, and would probably involve utilizing a similar class as the one used in SpecialNewLexeme.php ⇒ SpecialPageCopyrightView.php

Potential Plan of Action

  1. Implement the copyright message similarly to the SpecialNewLexeme page (by adding an element directly in PHP, see: SpecialNewLexeme.php#90), but ensure that it is displayed before submit and not before the form.
  2. Implement logged out warning similarly to the SpecialNewLexeme page (by displaying it before the form, see SpecialNewLexeme.php#312).
ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 10 2022, 1:03 PM
guergana.tzatchkova claimed this task.Aug 15 2022, 8:31 AM
guergana.tzatchkova moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Aug 18 2022, 12:55 PM

Change 824488 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/WikibaseLexeme@master] Add anonymous edit warning messag for nojs version

https://gerrit.wikimedia.org/r/824488

gerritbot added a project: Patch-For-Review.Aug 18 2022, 12:55 PM
guergana.tzatchkova added a comment.Aug 18 2022, 2:34 PM

As per the OOIU IconWidget demo page there is not yellow or gray color for the alert Icon besides black and blue (progressive). So I decided to leave the default icon color, black.

gerritbot added a comment.Aug 22 2022, 10:18 AM

Change 825292 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/WikibaseLexeme@master] Add copyright message in no javascript mode

https://gerrit.wikimedia.org/r/825292

Lydia_Pintscher added a parent task: T307866: Replace existing Special:NewLexeme page with the new one.Aug 23 2022, 7:45 AM
guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Aug 24 2022, 9:50 AM
gerritbot added a comment.Aug 29 2022, 12:11 PM

Change 824488 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add copyright message for nojs

https://gerrit.wikimedia.org/r/824488

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 29 2022, 1:00 PM
gerritbot added a comment.Aug 30 2022, 9:02 AM

Change 825292 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add anonymous edit warning in no javascript mode

https://gerrit.wikimedia.org/r/825292

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2022, 9:29 AM
guergana.tzatchkova moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Aug 30 2022, 9:38 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.28; 2022-09-05); removed MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 30 2022, 10:00 AM
Lydia_Pintscher moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.Aug 31 2022, 8:29 AM
Lydia_Pintscher subscribed.

\o/

Lydia_Pintscher closed this task as Resolved.Aug 31 2022, 8:29 AM
karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Sep 19 2022, 11:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL