Improve Phonos extension code coverage
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	TheresNoTime
	Aug 3 2022, 3:23 PM

Description

https://doc.wikimedia.org/cover-extensions/Phonos/ is suggesting we have a very low percentage of code covered by tests (~~though it doesn't appear to be entirely accurate, e.g. GoogleEngine is well covered but reports 0%~~) — it would be good to improve this a little though.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add EspeakEngine test and ignore all getAudioData() methods	mediawiki/extensions/Phonos	master	+28 -0
	Use @covers on the class scope, not methods	mediawiki/extensions/Phonos	master	+2 -6

Customize query in gerrit

Related Objects

Mentioned In: rEPHN9f991e10b3ec: Add EspeakEngine test and ignore all getAudioData() methods
rEPHN2d80854bbebd: Use @covers on the class scope, not methods

Event Timeline

TheresNoTime created this task.Aug 3 2022, 3:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2022, 3:23 PM

though it doesn't appear to be entirely accurate, e.g. GoogleEngine is well covered but reports 0%

It's completely accurate ;). You need to fully qualify the @covers in GoogleEngineTest like it is in LarynxEngineTest.

In T314498#8129994, @Reedy wrote:

though it doesn't appear to be entirely accurate, e.g. GoogleEngine is well covered but reports 0%

It's completely accurate ;). You need to fully qualify the @covers in GoogleEngineTest like it is in LarynxEngineTest.

Thank you @Reedy 😌

TheresNoTime updated the task description. (Show Details)Aug 3 2022, 11:43 PM

Change 820252 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/Phonos@master] Use @covers on the class scope, not methods

https://gerrit.wikimedia.org/r/820252

gerritbot added a project: Patch-For-Review.Aug 4 2022, 1:22 AM

Change 820252 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Use @covers on the class scope, not methods

https://gerrit.wikimedia.org/r/820252

MusikAnimal mentioned this in rEPHN2d80854bbebd: Use @covers on the class scope, not methods.Aug 4 2022, 1:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 4 2022, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 2:30 AM

Change 820260 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/Phonos@master] Add EspeakEngine test and ignore all getAudioData() methods

https://gerrit.wikimedia.org/r/820260

gerritbot added a project: Patch-For-Review.Aug 4 2022, 2:50 AM

Change 820260 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Add EspeakEngine test and ignore all getAudioData() methods

https://gerrit.wikimedia.org/r/820260

MusikAnimal mentioned this in rEPHN9f991e10b3ec: Add EspeakEngine test and ignore all getAudioData() methods.Aug 4 2022, 10:01 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 10:30 AM

TheresNoTime moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Aug 4 2022, 10:46 AM

• JMcLeod_WMF set the point value for this task to 2.Aug 9 2022, 2:23 PM

TheresNoTime moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.Aug 10 2022, 5:06 PM

• NRodriguez edited projects, added Community-Tech (CommTech-Sprint-31); removed Community-Tech.Aug 17 2022, 7:15 PM

Initial "issue" resolved, tests should be expected going forwards anyway 😄

• JMcLeod_WMF moved this task from Ready 🎬 to Done 🏁 on the Community-Tech (CommTech-Sprint-31) board.Aug 29 2022, 1:35 PM

Improve Phonos extension code coverageClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Improve Phonos extension code coverage
Closed, ResolvedPublic2 Estimated Story Points
Actions