Page MenuHomePhabricator
Create Task
Maniphest T31575

Handle summaries consisting of whitespace only consistently in contributions/history <-> watchlist/recent changes
Closed, ResolvedPublic
Actions

Description

If you enter just a space as summary for an edit this is handled inconsistently in different places:

In the user contributions and the page history the summary doesn't show up, there are no parentheses as for non-empty summaries. This is the behavior which is correct in my eyes.

In the watchlist and the recent changes the whitespace-summary is shown: There are parentheses with a space between them, which looks a bit ugly.

At least the summary should be treated the same in every place.

Version: 1.17.x
Severity: trivial

Details

Reference
bz29575

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:33 PM
• bzimport added a project: MediaWiki-Special-pages.
• bzimport set Reference to bz29575.
• bzimport added a subscriber: Unknown Object (MLST).
Schnark created this task.Jun 25 2011, 8:20 AM
MarkAHershberger added a comment.May 28 2012, 5:56 PM

Lowering priority on high priority bugs that have a low severity

Umherirrender added a comment.Mar 16 2013, 9:04 PM

With gerrit 36359 more summaries are trimmed before saving to database, that means summaries with spaces will roll out of the recentchanges table and the differences are not seen anymore. Feel free to mark as fixed, if you think, that is enough.

Aklapper added a comment.Mar 17 2013, 11:49 PM

Michael: Is the patch mentioned in comment 2 sufficient?

Schnark added a comment.Mar 25 2013, 9:19 AM

I used a space as summary to supress auto-summaries and warnings about missing summaries. If I understand the patch correctly, it removes this behavior, i.e. a space as summary will cause an autosummary/warning. If I'm the only one who used this, then it's ok for me, but if there are other users who used a space as summary for this, trimming the summary before everything else isn't the best way to do it.

Umherirrender added a comment.Mar 25 2013, 7:36 PM

Works for me, since gerrit 49483 the whitespace is stripped only on save, not on preview/show changes, and that is after forceeditsummary.

Schnark added a comment.Apr 10 2013, 10:48 AM

(In reply to comment #3)

Michael: Is the patch mentioned in comment 2 sufficient?

Yes, closing as fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL