Page MenuHomePhabricator

Adding a global account to override list gives DBTransactionSizeError
Closed, ResolvedPublicPRODUCTION ERROR

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • A DBTransactionSizeError is thrown:
To avoid creating high replication lag, this transaction was aborted because the write duration (3.800598859787) exceeded the 3 second limit. If you are changing many items at once, try doing multiple smaller operations instead.
[bf111084-04b7-4f02-bbcf-808b85e94a3b] /wiki/Special:SecurePoll/votereligibility/1364/edit/include   Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent 3.801s in writes, exceeding the 3s limit
from /srv/mediawiki/php-1.39.0-wmf.25/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1741)
#0 /srv/mediawiki/php-1.39.0-wmf.25/includes/libs/rdbms/lbfactory/LBFactory.php(410): Wikimedia\Rdbms\LoadBalancer->approvePrimaryChanges(array, string)
#1 /srv/mediawiki/php-1.39.0-wmf.25/includes/MediaWiki.php(671): Wikimedia\Rdbms\LBFactory->commitPrimaryChanges(string, array)
#2 /srv/mediawiki/php-1.39.0-wmf.25/includes/MediaWiki.php(641): MediaWiki::preOutputCommit(RequestContext, Closure)
#3 /srv/mediawiki/php-1.39.0-wmf.25/includes/MediaWiki.php(928): MediaWiki->doPreOutputCommit(Closure)
#4 /srv/mediawiki/php-1.39.0-wmf.25/includes/MediaWiki.php(562): MediaWiki->main()
#5 /srv/mediawiki/php-1.39.0-wmf.25/index.php(50): MediaWiki->run()
#6 /srv/mediawiki/php-1.39.0-wmf.25/index.php(46): wfIndexMain()
#7 /srv/mediawiki/w/index.php(3): require(string)
#8 {main}

What should have happened instead?:

  • The username should be added.

Other information (browser name/version, screenshots, etc.):

  • This can be worked around by adding only a local instance of the user to the override list, e.g. ArielGlenn@metawiki, and having the user vote from that wiki directly.
  • See also the very similar request T289797: Override list should allow for global usernames which should resolve this issue

Screenshot 2022-08-24 at 11.34.04 AM.png (401×1 px, 83 KB)

Event Timeline

Zabe updated the task description. (Show Details)
Zabe changed the subtype of this task from "Bug Report" to "Production Error".
Zabe subscribed.

Change 826511 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/SecurePoll@master] Use real transactions when managing the voter list for a poll

https://gerrit.wikimedia.org/r/826511

Change 826511 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Use real transactions when managing the voter list for a poll

https://gerrit.wikimedia.org/r/826511

Change 826614 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/SecurePoll@wmf/1.39.0-wmf.26] Use real transactions when managing the voter list for a poll

https://gerrit.wikimedia.org/r/826614

Change 826614 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.39.0-wmf.26] Use real transactions when managing the voter list for a poll

https://gerrit.wikimedia.org/r/826614

Mentioned in SAL (#wikimedia-operations) [2022-08-29T13:21:27Z] <taavi@deploy1002> Synchronized php-1.39.0-wmf.26/extensions/SecurePoll/: T316150 (duration: 03m 44s)

Zabe claimed this task.

Should be fixed.

Thanks for the work on this, but I just attempted to add another user to the same election and this time got the following error:
[bcca1d12-8e36-4307-a5c6-e66cf9d8f17e] 2022-08-29 16:20:31: Fatal exception of type "Error"

(This seems to happen whenever I add anyone to the list, not just global users, so I think this is a new bug.)

Change 827529 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/SecurePoll@master] Add missing comma

https://gerrit.wikimedia.org/r/827529

Change 827529 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Add missing comma

https://gerrit.wikimedia.org/r/827529

Change 827199 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/SecurePoll@wmf/1.39.0-wmf.26] Add missing comma

https://gerrit.wikimedia.org/r/827199

Legoktm triaged this task as Unbreak Now! priority.Aug 29 2022, 4:50 PM

Change 827199 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.39.0-wmf.26] Add missing comma

https://gerrit.wikimedia.org/r/827199

Mentioned in SAL (#wikimedia-operations) [2022-08-29T17:25:26Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.26/extensions/SecurePoll/includes/Pages/VoterEligibilityPage.php: 2d6c378fe509551607c382f96adf1c4fa4c4bad2: Add missing comma (T316150) (duration: 03m 47s)

Urbanecm subscribed.

The bug should now be actually fixed.