Page MenuHomePhabricator
Create Task
Maniphest T316525

Move Fresnel from PHP 7.2.x to 7.4.x
Closed, ResolvedPublic
Actions

Description

We're going to drop PHP 7.2 support moderately soon, so Fresnel should be moved over else it will not successfully run.

Details

SubjectRepoBranchLines +/-
jjb: [mediawiki-fresnel-patch-docker] Switch from php72 to php74 base imageintegration/configmaster+1 -1
dockerfiles: [quibble-fresnel] Switch from php72 to php74 base imageintegration/configmaster+8 -2
Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Aug 29 2022, 12:40 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptAug 29 2022, 12:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle claimed this task.Aug 29 2022, 7:06 PM
Krinkle triaged this task as Medium priority.
Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
gerritbot added a comment.Aug 31 2022, 2:16 PM

Change 828541 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] dockerfiles: [quibble-fresnel] Switch from php72 to php74 base image

https://gerrit.wikimedia.org/r/828541

gerritbot added a project: Patch-For-Review.Aug 31 2022, 2:16 PM

Change 828542 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: [mediawiki-fresnel-patch-docker] Switch from php72 to php74 base image

https://gerrit.wikimedia.org/r/828542

gerritbot added a comment.Aug 31 2022, 3:26 PM

Change 828541 merged by jenkins-bot:

[integration/config@master] dockerfiles: [quibble-fresnel] Switch from php72 to php74 base image

https://gerrit.wikimedia.org/r/828541

Stashbot added a comment.Aug 31 2022, 3:27 PM

Mentioned in SAL (#wikimedia-releng) [2022-08-31T15:27:46Z] <James_F> Docker: Building and publishing quibble-fresnel image based on php74 for T316525

gerritbot added a comment.Aug 31 2022, 3:39 PM

Change 828542 merged by jenkins-bot:

[integration/config@master] jjb: [mediawiki-fresnel-patch-docker] Switch from php72 to php74 base image

https://gerrit.wikimedia.org/r/828542

Jdforrester-WMF closed this task as Resolved.Aug 31 2022, 3:40 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Krinkle.

Deployed and tested; looks good (run on php72, re-build on php74).

Some apparent non-trivial improvement in TTFB but that may just be an artefact of differing CI load when the jobs were run.
Some apparent minor improvement in HTML bytes shipped, but that's likely just the PHP version string being much shorter ( PHP 7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf5 vs. PHP 7.4.30)

Krinkle added a comment.Aug 31 2022, 3:41 PM

Thanks @Jdforrester-WMF!

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2022, 4:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL