Page MenuHomePhabricator
Create Task
Maniphest T316716

Enable stricter phan checks in Translate
Open, MediumPublic
Actions

Description

To make phan stricter to catch more issues like T316575, also the Translate extension should disable the following phan config (which make phan stricter)

// These are too spammy for now. TODO enable
$cfg['null_casts_as_any_type'] = true;
$cfg['scalar_implicit_cast'] = true;

Details

SubjectRepoBranchLines +/-
phan: Disable null_casts_as_any_type setting and make passmediawiki/extensions/Translatemaster+148 -48
build: Disable phan option scalar_implicit_cast and make passmediawiki/extensions/Translatemaster+17 -13
Fix a few phan warningsmediawiki/extensions/Translatemaster+15 -39
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Aug 30 2022, 8:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2022, 8:09 PM
Umherirrender mentioned this in T316575: SecurePoll's phan CI has been configured such that it did not catch a missing comma.Aug 30 2022, 8:09 PM
Umherirrender moved this task from Backlog to Extensions on the phan board.Aug 30 2022, 8:12 PM
Umherirrender unsubscribed.Aug 31 2022, 8:05 PM
Nikerabbit triaged this task as Medium priority.Sep 12 2022, 11:20 AM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
gerritbot added a comment.Sep 12 2022, 2:17 PM

Change 831567 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Fix a few phan warnings

https://gerrit.wikimedia.org/r/831567

gerritbot added a project: Patch-For-Review.Sep 12 2022, 2:17 PM
gerritbot added a comment.Sep 13 2022, 7:17 AM

Change 831567 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Fix a few phan warnings

https://gerrit.wikimedia.org/r/831567

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2022, 7:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 13 2022, 8:00 AM
gerritbot added a comment.Apr 12 2023, 7:47 PM

Change 908338 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] build: Disable phan option scalar_implicit_cast and make pass

https://gerrit.wikimedia.org/r/908338

gerritbot added a project: Patch-For-Review.Apr 12 2023, 7:47 PM
abi_ added a project: Language-Team (Language-2023-April-June).Apr 14 2023, 9:14 AM
abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-April-June) board.
gerritbot added a comment.Apr 18 2023, 8:29 AM

Change 908338 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] build: Disable phan option scalar_implicit_cast and make pass

https://gerrit.wikimedia.org/r/908338

Maintenance_bot removed a project: Patch-For-Review.Apr 18 2023, 8:30 AM
gerritbot added a comment.May 3 2023, 9:48 PM

Change 914898 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] phan: Disable null_casts_as_any_type setting and make pass

https://gerrit.wikimedia.org/r/914898

gerritbot added a project: Patch-For-Review.May 3 2023, 9:48 PM
Umherirrender claimed this task.May 3 2023, 9:50 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 3:01 PM
gerritbot added a comment.May 17 2023, 5:26 PM

Change 914898 abandoned by Umherirrender:

[mediawiki/extensions/Translate@master] phan: Disable null_casts_as_any_type setting and make pass

Reason:

Repo under refactoring, big patch set like this are hard to keep up to date

https://gerrit.wikimedia.org/r/914898

Umherirrender removed Umherirrender as the assignee of this task.May 17 2023, 5:26 PM
Umherirrender removed a project: Patch-For-Review.
Umherirrender subscribed.
Nikerabbit removed a project: Language-Team (Language-2023-April-June).May 25 2023, 8:35 AM
Nikerabbit subscribed.

Removing from sprint board as there is nothing to review currently.

Umherirrender unsubscribed.Jul 12 2023, 8:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL