Page MenuHomePhabricator
Create Task
Maniphest T317542

Remove seconds from time selectors on Special:(Enable|Edit)EventRegistration
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

We can use a custom date formatter to remove them.

AC
  • Time format on Special:(Enable|Edit)EventRegistration is HH:mm, not HH:mm:ss

Details

SubjectRepoBranchLines +/-
Remove seconds from time selectors when editing a registrationmediawiki/extensions/CampaignEventsmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Sep 12 2022, 2:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2022, 2:58 PM
gerritbot added a comment.Sep 12 2022, 3:01 PM

Change 831592 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Remove seconds from time selectors when editing a registration

https://gerrit.wikimedia.org/r/831592

gerritbot added a project: Patch-For-Review.Sep 12 2022, 3:01 PM
Daimona moved this task from Needs Input / Design in progress to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Sep 12 2022, 3:01 PM
gerritbot added a comment.Oct 7 2022, 5:33 PM

Change 831592 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Remove seconds from time selectors when editing a registration

https://gerrit.wikimedia.org/r/831592

Daimona mentioned this in rUCAM7032bcc69e62: Remove seconds from time selectors when editing a registration.Oct 7 2022, 5:35 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 7 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2022, 6:30 PM
Daimona set the point value for this task to 0.Oct 7 2022, 10:49 PM
Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 8 2022, 12:21 AM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 10 2022, 5:26 PM
vaughnwalters subscribed.

✅ Time format on Special:(Enable|Edit)EventRegistration is HH:mm, not HH:mm:ss. Moving to product sign off

Screen Shot 2022-10-10 at 12.09.28 PM.png (310×1 px, 121 KB)

Screen Shot 2022-10-10 at 12.23.23 PM.png (336×950 px, 117 KB)

ifried closed this task as Resolved.Oct 13 2022, 2:01 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
ifried subscribed.

I have tested this on the beta cluster, and the seconds are no longer displayed in the time selector. I'm marking this as Done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL