Remove Adyen WSDL classes and related code in Api.php and PaymentProvider classes
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

None

Authored By

	Ejegg
	Sep 15 2022, 2:07 AM

Description

Once all the IPNs are switched to JSON and the API calls are all made via REST, remove all the WSDL classes that are checked in to the SmashPig repo as well as the code for making SOAP requests and handling SOAP responses.

Details

Subject	Repo	Branch	Lines +/-
Clean up WSDL stuff from Api.php	wikimedia/fundraising/SmashPig	master	+16 -88
Remove old WSDL recurring authorize method	wikimedia/fundraising/SmashPig	master	+11 -93
Add Adyen multilistener and REST listener	wikimedia/fundraising/SmashPig	master	+189 -1
Remove the WSDL directdebit method iDEAL and newer bank transfers are using the new methods	wikimedia/fundraising/SmashPig	master	+0 -39
Test data for Adyen JSON IPNs	wikimedia/fundraising/SmashPig	master	+546 -0
Remove unused classmap and wsdlPath	wikimedia/fundraising/SmashPig	master	+2 -19

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T291448 Epic: Remove old Adyen code
		Resolved		None	T317837 Remove Adyen WSDL classes and related code in Api.php and PaymentProvider classes

Event Timeline

Ejegg created this task.Sep 15 2022, 2:07 AM

XenoRyet moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Sep 19 2022, 7:44 PM

Dwisehaupt set the point value for this task to 2.Oct 3 2022, 8:39 PM

XenoRyet moved this task from Sprint +1 to Later on the Fundraising-Backlog board.Nov 22 2022, 9:29 PM

Ejegg mentioned this in T317422: Investigate timeouts from Adyen Soap listener.Jan 23 2023, 9:49 PM

@jgleeson wondering if you have any insight as to whether these classes have been removed. Happy to share more context in a stand.

AKanji-WMF moved this task from Later to Current Sprint on the Fundraising-Backlog board.Jan 30 2024, 8:30 PM

AKanji-WMF added a project: Fundraising Sprint: brb().Jan 30 2024, 9:10 PM

Change 997897 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Remove unused classmap and wsdlPath

https://gerrit.wikimedia.org/r/997897

gerritbot added a project: Patch-For-Review.Feb 6 2024, 3:37 PM

Looks like we can just add a getInstanceFromJSON method to the AdyenMessage class that parallels the current getInstanceFromWSDL method.

Then we also add a constructFromJSON to replace constructFromWSDL, on AdyenMessage and any subclasses that override the WSDL one.

Change 997897 abandoned by Ejegg:

[wikimedia/fundraising/SmashPig@master] Remove unused classmap and wsdlPath

Reason:

oops, those are used in the parent class

https://gerrit.wikimedia.org/r/997897

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2024, 10:31 PM

In T317837#9519241, @Ejegg wrote:

Looks like we can just add a getInstanceFromJSON method to the AdyenMessage class that parallels the current getInstanceFromWSDL method.

Then we also add a constructFromJSON to replace constructFromWSDL, on AdyenMessage and any subclasses that override the WSDL one.

OK, that was a very hasty analysis. We need to replace the AdyenListener entirely as it inherits from SoapListener. We can run both listeners in parallel on a short term basis, instantiating the appropriate one based on the first char of the notification.

Change 997969 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Test data for Adyen JSON IPNs

https://gerrit.wikimedia.org/r/997969

Change 997998 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] WIP adyen multilistener

https://gerrit.wikimedia.org/r/997998

Change 997969 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Test data for Adyen JSON IPNs

https://gerrit.wikimedia.org/r/997969

AKanji-WMF edited projects, added Fundraising Sprint: canOfWorms(🪱); removed Fundraising Sprint: brb().Feb 13 2024, 9:23 PM

Change 1003575 had a related patch set uploaded (by Cstone; author: Cstone):

[wikimedia/fundraising/SmashPig@master] Remove the WSDL directdebit method iDEAL and newer bank transfers are using the new methods