Page MenuHomePhabricator

Consider replacing the heavy-weight quibble-composertest jobs with normal composer jobs, for speed
Closed, DeclinedPublic

Event Timeline

Change 833022 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Link to T318093 for the related FIXMEs

https://gerrit.wikimedia.org/r/833022

Change 833022 merged by jenkins-bot:

[integration/config@master] Zuul: Link to T318093 for the related FIXMEs

https://gerrit.wikimedia.org/r/833022

The job only runs against mediawiki/core. It runs Quibble composer-test stage which when triggered for mediawiki/core has a few optimizations:

  • run a full composer test when composer.json or .phpcs.xml has been touched by HEAD
  • skip unless HEAD touches any of php, php5, inc, sample files
  • trigger composer run test-some passing the list of altered php files as parameter

This way it makes the composer lint stage faster.

If we were to run the default jobs doing composer run test we would end up always running php-parallel-lint / phpcs against every single file.

References:

Speed up by only testing altered files:

Introduction of the dedicated job (which was made to stop running composer lint in the other jobs)

Change 836976 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Drop FIXME messages for T318093, being Declined

https://gerrit.wikimedia.org/r/836976

Change 836976 merged by jenkins-bot:

[integration/config@master] Zuul: Drop FIXME messages for T318093, being Declined

https://gerrit.wikimedia.org/r/836976

Mentioned in SAL (#wikimedia-releng) [2022-09-30T02:27:42Z] <James_F> Zuul: Drop FIXME messages for T318093, being Declined