Display "None" instead of an empty table in Special:ManageMentors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Sep 24 2022, 9:51 AM

Description

Special:ManageMentors shows a list of mentors. Currently, when there are no mentors, the table header is displayed, and not populated with any rows, see screenshot:

This is unusual. Instead, let's display none instead.

Acceptance criteria

Special:ManageMentors show none when the wiki has no automatically/manually assigned mentors.

Details

	Subject	Repo	Branch	Lines +/-
	SpecialManageMentors: Display "None" when there are no mentors to display	mediawiki/extensions/GrowthExperiments	master	+10 -0

Customize query in gerrit

Related Objects

Mentioned Here: T318274: Explain how to add your name to Special:ManageMentors

Event Timeline

Urbanecm_WMF created this task.Sep 24 2022, 9:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2022, 9:51 AM

Urbanecm_WMF triaged this task as Medium priority.Sep 24 2022, 9:51 AM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 24 2022, 9:55 AM

Change 834635 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SpecialManageMentors: Display "None" when there are no mentors to display

https://gerrit.wikimedia.org/r/834635

gerritbot added a project: Patch-For-Review.Sep 24 2022, 9:55 AM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 26 2022, 8:36 AM

This is ready for QA when the patch for T318274: Explain how to add your name to Special:ManageMentors is merged, but code review is done so leaving in the QA column.

Change 834635 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialManageMentors: Display "None" when there are no mentors to display

https://gerrit.wikimedia.org/r/834635

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2022, 8:31 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Sep 27 2022, 9:00 PM

Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Sep 29 2022, 10:00 AM

Checked in betalabs:

Screen Shot 2022-10-21 at 5.08.50 PM.png (394×851 px, 27 KB)

	F35609883: Screen Shot 2022-10-21 at 5.08.50 PM.png
	Oct 22 2022, 12:14 AM

Display "None" instead of an empty table in Special:ManageMentorsClosed, ResolvedPublicActions