Page MenuHomePhabricator
Create Task
Maniphest T318617

Bug (not yet deployed): Adyen no longer shows error page
Closed, ResolvedPublic
Actions

Description

Following this change, the redirect to the error page gets overridden by the subsequent redirect to the ThankYou page.

Details

SubjectRepoBranchLines +/-
Return after redirecting to fail pagemediawiki/extensions/DonationInterfacemaster+1 -0
Customize query in gerrit

Event Timeline

AndyRussG created this task.Sep 26 2022, 7:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2022, 7:28 PM
Ejegg subscribed.Sep 26 2022, 7:32 PM

Oops, looks like there should be a 'return' after that redirect in the isFailed block.

jgleeson subscribed.Sep 26 2022, 7:35 PM

ah. not run into that one before.

XenoRyet moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.Sep 26 2022, 7:43 PM
gerritbot added a comment.Sep 26 2022, 7:45 PM

Change 835261 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Return after redirecting to fail page

https://gerrit.wikimedia.org/r/835261

gerritbot added a project: Patch-For-Review.Sep 26 2022, 7:45 PM
AndyRussG added a comment.Sep 27 2022, 3:36 AM

Screenshots demonstrating the issue:

Screenshot from 2022-09-26 22-28-30.png (844×1 px, 504 KB)

Screenshot from 2022-09-26 22-29-52.png (844×1 px, 499 KB)

This was triggered on the current master branch of DonationInterface, simply by entering incorrect date and cvv information for a test credit card. I guess it may be somewhat browser dependent, but it did happen to me on both Chrome and Firefox. The attached patch fixes the issue.

gerritbot added a comment.Sep 27 2022, 3:41 AM

Change 835261 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Return after redirecting to fail page

https://gerrit.wikimedia.org/r/835261

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Sep 27 2022, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 27 2022, 4:30 AM
XenoRyet added a project: Fundraising Tech - Chaos Crew.Sep 27 2022, 5:11 PM
AndyRussG moved this task from Backlog to Completed 20220913 - 20220927 on the Fundraising Tech - Chaos Crew board.Sep 27 2022, 7:12 PM
XenoRyet closed this task as Resolved.Sep 27 2022, 7:14 PM
XenoRyet set Final Story Points to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits