Page MenuHomePhabricator
Create Task
Maniphest T318793

🥦️ Add missing conditional headers and corresponding responses to OAS definition for edit requests
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
REST: Add missing specs for conditional GET reqsmediawiki/extensions/Wikibasemaster+13 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE created this task.Sep 28 2022, 10:33 AM
Silvan_WMDE removed a project: Story.
Silvan_WMDE mentioned this in T318221: 🥦️ Handle conditional http headers in Wikibase REST API.Sep 28 2022, 11:12 AM
Jakob_WMDE claimed this task.Sep 30 2022, 11:10 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 14) board.
gerritbot added a comment.Sep 30 2022, 2:06 PM

Change 837124 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add missing specs for conditional GET reqs

https://gerrit.wikimedia.org/r/837124

gerritbot added a project: Patch-For-Review.Sep 30 2022, 2:06 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 14) board.Sep 30 2022, 2:38 PM
gerritbot added a comment.Oct 4 2022, 1:12 PM

Change 837124 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add missing specs for conditional GET reqs

https://gerrit.wikimedia.org/r/837124

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2022, 1:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 4 2022, 2:00 PM
Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 14) board.Oct 4 2022, 2:56 PM
Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Oct 5 2022, 9:25 AM
Jakob_WMDE moved this task from Done to To Do on the Wikibase Product Platform (v1) (Sprint 14) board.

Moving back to "to do" since I confused this task with T318717 and the patch I made clearly had nothing to do with edit routes. Oopsie.

Ollie.Shotton_WMDE claimed this task.Oct 5 2022, 5:00 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 14) board.
Ollie.Shotton_WMDE added a comment.Oct 5 2022, 5:15 PM

Nothing left to do on this one either! Completed in previous tasks.

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 14) board.Oct 5 2022, 5:15 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 14) board.Oct 6 2022, 12:38 PM

Stared at it and agree there's nothing left to do.

WMDE-leszek closed this task as Resolved.Oct 14 2022, 12:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL