Maniphest T319000

PHP Deprecated: trim()
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Install MediaWiki with PHP 8.1.1

What happens?:

PHP error log: PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/dirkeinecke/..../includes/installer/WebInstaller.php on line 1071

Details

	Subject	Repo	Branch	Lines +/-
	WebInstaller: Don't try and run trim() on null	mediawiki/core	REL1_35	+1 -1
	WebInstaller: Don't try and run trim() on null	mediawiki/core	master	+1 -1
	WebInstaller: Don't try and run trim() on null	mediawiki/core	REL1_39	+1 -1
	WebInstaller: Don't try and run trim() on null	mediawiki/core	REL1_38	+1 -1

Customize query in gerrit

Event Timeline

dirkeinecke created this task.Sep 30 2022, 7:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2022, 7:03 AM

Mainframe98 added projects: PHP 8.1 support, MediaWiki-Installer.Sep 30 2022, 7:15 AM

Can you advise which version of MW this is on please?

This function is a bit weird. It trims the value, and then later on checks to see if the value is null, which would be impossible since trim( null ) === ''

In T319000#8280157, @Reedy wrote:

Can you advise which version of MW this is on please?

1.38.4

Reedy moved this task from General to Web installer on the MediaWiki-Installer board.Oct 4 2022, 4:10 PM

Reedy added projects: MW-1.38-release, MW-1.39-release.Oct 4 2022, 11:28 PM

Change 838280 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838280

gerritbot added a project: Patch-For-Review.Oct 4 2022, 11:30 PM

Change 838280 merged by jenkins-bot:

[mediawiki/core@master] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838280

Change 838819 had a related patch set uploaded (by Jforrester; author: Reedy):

[mediawiki/core@REL1_39] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838819

Change 838820 had a related patch set uploaded (by Jforrester; author: Reedy):

[mediawiki/core@REL1_38] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838820

Change 838819 merged by jenkins-bot:

[mediawiki/core@REL1_39] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838819

Change 838820 merged by jenkins-bot:

[mediawiki/core@REL1_38] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838820

ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 5 2022, 9:00 PM

Reedy closed this task as Resolved.Oct 6 2022, 2:44 AM

Reedy claimed this task.

Change 838825 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838825

Change 838825 merged by jenkins-bot:

[mediawiki/core@REL1_35] WebInstaller: Don't try and run trim() on null

https://gerrit.wikimedia.org/r/838825

ReleaseTaggerBot added a project: MW-1.35-notes.Oct 6 2022, 3:00 AM