Page MenuHomePhabricator
Create Task
Maniphest T319340

Replace deprecated global url utils functions (wfExpandUrl/wfParseUrl and friends)
Open, Needs TriagePublic
Actions

Description

RELEASE-NOTES-1.39
* The following global functions are deprecated in favor of the listed UrlUtils
  methods.
  - wfExpandUrl -> UrlUtils::expand
  - wfGetServerUrl -> UrlUtils::getServer
  - wfAssembleUrl -> UrlUtils::assemble
  - wfRemoveDotSegments -> UrlUtils::removeDotSegments
  - wfUrlProtocols -> UrlUtils::validProtocols
  - wfUrlProtocolsWithoutProtRel -> UrlUtils::validAbsoluteProtocols
  - wfParseUrl -> UrlUtils::parse
  - wfExpandIRI -> UrlUtils::expandIRI
  - wfMatchesDomainList -> UrlUtils::matchesDomainList
  These methods are exact replacements except that
  1) they return null instead of false or empty string on error (where
     applicable);
  2) UrlUtils::validProtocols does not take a parameter (documentation said not
     to pass one to wfUrlProtocols anyway);

https://codesearch-beta.wmcloud.org/search/?q=%5Cb%28wfExpandUrl%7CwfGetServerUrl%7CwfAssembleUrl%7CwfRemoveDotSegments%7CwfUrlProtocols%7CwfUrlProtocolsWithoutProtRel%7CwfParseUrl%7CwfExpandIRI%7CwfMatchesDomainList%29%5Cb&files=%5C.php%24&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
core: Replace deprecated calls to wfExpandUrl with UrlUtils::expandmediawiki/coremaster+42 -19
tests: Replace deprecated calls to wfExpandUrl with hard-coded urlmediawiki/coremaster+14 -12
API: Replace deprecated calls to wfExpandUrl with UrlUtils::expandmediawiki/coremaster+124 -35
Replace some deprecated wfExpandUrl calls with UrlUtils::expandmediawiki/coremaster+24 -11
Replace deprecated wfParseUrlmediawiki/extensions/LandingCheckmaster+28 -27
filerepo: Replace deprecated wfExpandUrlmediawiki/coremaster+18 -8
specials: Replace deprecated wfExpandUrl/wfParseUrlmediawiki/coremaster+50 -10
Customize query in gerrit

Event Timeline

Umherirrender created this task.Oct 4 2022, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2022, 7:57 PM
gerritbot added a comment.Oct 4 2022, 8:13 PM

Change 838259 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specials: Replace deprecated wfExpandUrl/wfParseUrl

https://gerrit.wikimedia.org/r/838259

gerritbot added a project: Patch-For-Review.Oct 4 2022, 8:13 PM
gerritbot added a comment.Oct 5 2022, 3:23 PM

Change 838259 merged by jenkins-bot:

[mediawiki/core@master] specials: Replace deprecated wfExpandUrl/wfParseUrl

https://gerrit.wikimedia.org/r/838259

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2022, 3:29 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 5 2022, 4:00 PM
gerritbot added a comment.Oct 5 2022, 7:41 PM

Change 838883 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] filerepo: Replace deprecated wfExpandUrl

https://gerrit.wikimedia.org/r/838883

gerritbot added a project: Patch-For-Review.Oct 5 2022, 7:41 PM
gerritbot added a comment.Oct 8 2022, 6:30 PM

Change 838883 merged by jenkins-bot:

[mediawiki/core@master] filerepo: Replace deprecated wfExpandUrl

https://gerrit.wikimedia.org/r/838883

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2022, 7:30 PM
gerritbot added a comment.Dec 28 2022, 3:23 PM

Change 873008 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LandingCheck@master] Replace deprecated wfParseUrl

https://gerrit.wikimedia.org/r/873008

gerritbot added a project: Patch-For-Review.Dec 28 2022, 3:23 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 2 2023, 9:18 PM
Restricted Application added a subscriber: Lens0021. · View Herald TranscriptMar 2 2023, 9:18 PM
gerritbot added a comment.Mar 2 2023, 9:28 PM

Change 873008 merged by jenkins-bot:

[mediawiki/extensions/LandingCheck@master] Replace deprecated wfParseUrl

https://gerrit.wikimedia.org/r/873008

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2023, 9:31 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Mar 2 2023, 10:00 PM
alistair3149 updated the task description. (Show Details)Mar 27 2023, 6:47 PM
gerritbot added a comment.May 30 2023, 7:48 PM

Change 924589 had a related patch set uploaded (by D3r1ck01; author: Jforrester):

[mediawiki/core@master] Replace some deprecated wfExpandUrl calls with UrlUtils::expand

https://gerrit.wikimedia.org/r/924589

gerritbot added a project: Patch-For-Review.May 30 2023, 7:48 PM
gerritbot added a comment.May 30 2023, 9:24 PM

Change 924589 merged by jenkins-bot:

[mediawiki/core@master] Replace some deprecated wfExpandUrl calls with UrlUtils::expand

https://gerrit.wikimedia.org/r/924589

Maintenance_bot removed a project: Patch-For-Review.May 30 2023, 9:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 30 2023, 10:00 PM
gerritbot added a comment.May 31 2023, 10:12 PM

Change 925059 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] API: Replace deprecated calls to wfExpandUrl with UrlUtils::expand

https://gerrit.wikimedia.org/r/925059

gerritbot added a project: Patch-For-Review.May 31 2023, 10:12 PM

Change 925060 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] tests: Replace deprecated calls to wfExpandUrl with UrlUtils::expand

https://gerrit.wikimedia.org/r/925060

gerritbot added a comment.Jun 22 2023, 8:09 PM

Change 932327 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] core: Replace deprecated calls to wfExpandUrl with UrlUtils::expand

https://gerrit.wikimedia.org/r/932327

gerritbot added a comment.Jun 23 2023, 5:17 PM

Change 925059 merged by jenkins-bot:

[mediawiki/core@master] API: Replace deprecated calls to wfExpandUrl with UrlUtils::expand

https://gerrit.wikimedia.org/r/925059

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 23 2023, 6:00 PM
gerritbot added a comment.Jun 23 2023, 6:50 PM

Change 925060 merged by jenkins-bot:

[mediawiki/core@master] tests: Replace deprecated calls to wfExpandUrl with hard-coded url

https://gerrit.wikimedia.org/r/925060

gerritbot added a comment.Jun 24 2023, 11:20 AM

Change 932327 merged by jenkins-bot:

[mediawiki/core@master] core: Replace deprecated calls to wfExpandUrl with UrlUtils::expand

https://gerrit.wikimedia.org/r/932327

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2023, 11:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL