Page MenuHomePhabricator
Create Task
Maniphest T320339

PageTriage tests failing due to assertArraySubset dependency
Closed, ResolvedPublic
Actions

Description

PhpUnit was recently bumped to 9.5, which removes assertArraySubset. This is blocking merges on PageTriage, which relied on ArraySubset directly as a Constraint.

Related log output from https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/59563/console:

09:52:20 1) ApiPageTriageListTest::testCreateDraftPage
09:52:20 Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found

Will need to remove all references to ArraySubset whenever possible for tests to work again. I have a patch ready but will need someone to review and merge.

Details

SubjectRepoBranchLines +/-
Remove usage of ArraySubset in testsmediawiki/extensions/PageTriagemaster+16 -29
Customize query in gerrit

Related Objects
Search...

Event Timeline

Chlod created this task.Oct 9 2022, 5:57 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 9 2022, 5:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 9 2022, 5:58 AM

Change 840495 had a related patch set uploaded (by Chlod Alejandro; author: Chlod Alejandro):

[mediawiki/extensions/PageTriage@master] Remove usage of ArraySubset in tests

https://gerrit.wikimedia.org/r/840495

gerritbot added a project: Patch-For-Review.Oct 9 2022, 5:58 AM
Chlod moved this task from Backlog to Code Review on the PageTriage board.Oct 9 2022, 6:02 AM
Chlod added a parent task: T243600: Migrate MediaWiki core (and thus extensions and skins) to PHPUnit 9.
taavi added a project: ci-test-error (WMF-deployed Build Failure).Oct 9 2022, 6:23 AM
gerritbot added a comment.Oct 9 2022, 6:25 AM

Change 840495 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove usage of ArraySubset in tests

https://gerrit.wikimedia.org/r/840495

MPGuy2824 moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Oct 9 2022, 6:27 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 9 2022, 6:30 AM
MPGuy2824 awarded a token.Oct 9 2022, 6:32 AM
taavi closed this task as Resolved.Oct 9 2022, 6:59 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 9 2022, 7:00 AM
Novem_Linguae moved this task from Waiting for enwiki deploy to Done on the PageTriage board.Oct 9 2022, 9:17 AM
Daimona subscribed.Oct 9 2022, 11:41 AM

FTR, we handled the assertArraySubset while updating to PHPUnit 8 (not a typo, I really mean eight) a while ago, see T244095. A replacement was created in MW core, assertArraySubmapSame. However, we didn't think about direct usages of the ArraySubset constraint...

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL