Page MenuHomePhabricator

Proposal: remove scrollbar in function editor in favor of sticky "work summary"
Closed, ResolvedPublic

Description

I feel like the scrollbar of the function definition tab causes troubles:

  • technically, it causes side effects like T312121 and T320271;
  • in term of UX, when the browser window is not big enough, the user gets a double scrollbar on Desktop (one for the webpage, the other for the "function definition" container);

I assume that the reason of the maximum height (causing the scrollbar) for the container is to always have the the "Work summary" on the right of the screen.

If I am right and if that's the only reason, I propose to set the "Work summary" sticky and remove the maximum height for the function definition (so no more scrollbar).

Here is a video which shows how it would look like (the video is not smooth, but the rendering on the browser is!). What do you think?

Event Timeline

Change 841894 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/extensions/WikiLambda@master] Remove the Function Definition scrollbar in favor of sticky work summary

https://gerrit.wikimedia.org/r/841894

The patch above implements the proposal.

Note that the sticky won't work on Internet Explorer 11. Though I am confident that it will just be ignored and it does not deteriorate the user experience much. If you agree with the proposal, I can take a look on how it is rendered on it.

Hey Teleosteen - thanks for the patch!

For some context, the reasoning for the maximum height is because a core value of Wikifunctions was encouraging translations as contributions, since many people won’t be able to make technical contributions. We didn’t want to the option to translate to be hidden since it’s a meaty way to contribute.

That being said, we agree that it the current state is not ideal and think this looks great! Right now we are working on modifications to the new publish component, after which we're going to get "for free" additional vertical real estate for the function definition, addressing the potential double scrollbar on desktop.

I'm going to merge the patch, but wanted to give you a heads up things might change a bit in the near future. Thanks so much for the work :)

Change 841894 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove the Function Definition scrollbar in favor of sticky work summary

https://gerrit.wikimedia.org/r/841894

Thanks @JKieserman for the heads up!

I don't mind any at all when part of my work is rolled back by further improvements, it's part of the job of programmer I truly think :-)