Page MenuHomePhabricator

Opening specific page causes a timeout
Closed, ResolvedPublic

Description

Trying to open page http://fi.wikipedia.org/wiki/Template:P%C3%A4iv%C3%A4malline
causes i timeout. Viewing the source works:
http://fi.wikipedia.org/w/index.php?title=Template:P%C3%A4iv%C3%A4malline&action=edit
. I Suspect that it has something to do with recursion as there is
{{{{PAGENAME}}}} in the source.


Version: 1.4.x
Severity: normal
URL: http://fi.wikipedia.org/wiki/Template:P%C3%A4iv%C3%A4malline

Details

Reference
bz1210
TitleReferenceAuthorSource BranchDest Branch
Add fundraising-tech architecture diagramrepos/fundraising-tech/fr-tech-diagrams!4jgleesonstack_diagrammain
Customize query in GitLab

Revisions and Commits

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:02 PM
bzimport set Reference to bz1210.
bzimport added a subscriber: Unknown Object (MLST).

That cause an infinite loop: the template is calling itself.
So basicly don't use it :o)

What are you trying todo exactly ?

It's used to include short summary according of given date to date page. Look
for example http://fi.wikipedia.org/wiki/1._tammikuuta . I thought infine loops
were hammered out? Also i think brion investigated the page already and got some
weird results.

rowan.collins wrote:

Oh, I get it. For those still staring in confusion, as I was, the trick is that
*once used on a page*, {{PAGENAME}} refers to the page *containing* the
template, not the template itself. So because {{foo}} causes the inclusion of
[[Template:Foo]], not [[Foo]], {{{{PAGENAME}}}} *on anything other than a
Template page* includes the *template* with the same name as the current
article. i.e. within the article [[Bar]] {{{{PAGENAME}}}} is actually equivalent
to {{Template:Bar}}. So that template does make sense, it just eats itself when
you view it directly.

As for the bug, I wonder if the problem is that the code never checks for a page
*directly* including itself, because it seems such an odd thing to happen?
Unless, of course, the bug is caused by something else on the page...

Oh, and I think there's a possible workaround - if the template wasn't stored in
the template namespace (move it to Wikipedia:Päivämalline or something) it
wouldn't be trying to include itself any more (it would be trying to include
Template:Päivämalline, which then wouldn't exist).

zigger wrote:

Loop detection seems to have been improved by Brion since 1.4beta6 about a week ago.

zigger wrote:

Marking as fixed, because none of the revisions of the supplied URL cause a
timeout any more (fi now running REL1_4rc1+).

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:21 AM