Page MenuHomePhabricator
Create Task
Maniphest T321075

Remove Gerrit motd plugin
Closed, ResolvedPublic
Actions

Description

We have the motd Gerrit plugin installed. That was done back in 2018 as a potential way to inform people having trouble to fetch when a branch got removed: T190810. We never used the feature and should remove it.

  • remove motd from the the wmf/stable-* branches
  • remove etc/motd.config from the deploy/wmf/stable-* branches
  • remove the Puppet managed symlink from $GERRIT_SITE/etc/motd.config to the deployed file
  • ensure both plugins/motd.jar and etc/motd.config are gone after deployment

Details

SubjectRepoBranchLines +/-
Remove motd pluginoperations/software/gerritwmf/stable-3.4+0 -4
gerrit: remove etc/motd.configoperations/puppetproduction+0 -8
Remove motd pluginoperations/software/gerritwmf/stable-3.5+0 -4
Remove motd plugin and its configoperations/software/gerritdeploy/wmf/stable-3.5+0 -1
Remove motd plugin and its configoperations/software/gerritdeploy/wmf/stable-3.4+0 -1
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Oct 18 2022, 1:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2022, 1:30 PM
hashar mentioned this in T190810: Install motd plugin.Oct 18 2022, 1:30 PM
hashar updated the task description. (Show Details)
gerritbot added a comment.Oct 18 2022, 1:35 PM

Change 843945 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.4] Remove motd plugin

https://gerrit.wikimedia.org/r/843945

gerritbot added a project: Patch-For-Review.Oct 18 2022, 1:35 PM

Change 843946 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.4] Remove motd plugin and its config

https://gerrit.wikimedia.org/r/843946

gerritbot added a comment.Oct 18 2022, 1:38 PM

Change 843947 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.5] Remove motd plugin

https://gerrit.wikimedia.org/r/843947

gerritbot added a comment.Oct 18 2022, 1:38 PM

Change 843948 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.5] Remove motd plugin and its config

https://gerrit.wikimedia.org/r/843948

gerritbot added a comment.Oct 18 2022, 1:42 PM

Change 843949 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] gerrit: remove etc/motd.config

https://gerrit.wikimedia.org/r/843949

hashar added a subscriber: • demon.Oct 18 2022, 1:43 PM

@demon you got the motd plugin added to Gerrit back in 2018 via T190810 but we never used it. I am thus going to remove it if that sounds good to you ;)

gerritbot added a comment.Oct 18 2022, 1:54 PM

Change 843946 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.4] Remove motd plugin and its config

https://gerrit.wikimedia.org/r/843946

gerritbot added a comment.Oct 18 2022, 1:58 PM

Change 843948 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.5] Remove motd plugin and its config

https://gerrit.wikimedia.org/r/843948

Stashbot added a comment.Oct 18 2022, 3:49 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-18T15:49:58Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@da5de16]: gerrit2002: remove motd plugin and its config # T321075

Stashbot added a comment.Oct 18 2022, 3:50 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-18T15:50:08Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@da5de16]: gerrit2002: remove motd plugin and its config # T321075 (duration: 00m 10s)

Stashbot added a comment.Oct 18 2022, 3:51 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-18T15:51:22Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@da5de16]: gerrit1001: remove motd plugin and its config # T321075

Stashbot added a comment.Oct 18 2022, 3:51 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-18T15:51:30Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@da5de16]: gerrit1001: remove motd plugin and its config # T321075 (duration: 00m 08s)

hashar added a comment.Oct 18 2022, 3:52 PM

On gerrit2002 (replica)

[2022-10-18T15:50:10.886Z] [PluginScanner] INFO com.google.gerrit.server.plugins.PluginLoader : Unloading plugin motd, version 3d174f8

On gerrit1001 (primary)

[2022-10-18T15:51:56.462Z] [PluginScanner] INFO com.google.gerrit.server.plugins.PluginLoader : Unloading plugin motd, version 3d174f8

Rest of plugins got unloaded/reloaded as well.

hashar updated the task description. (Show Details)Oct 18 2022, 4:02 PM
gerritbot added a comment.Oct 18 2022, 4:11 PM

Change 843947 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.5] Remove motd plugin

https://gerrit.wikimedia.org/r/843947

gerritbot added a comment.Oct 18 2022, 4:42 PM

Change 843949 merged by Dzahn:

[operations/puppet@production] gerrit: remove etc/motd.config

https://gerrit.wikimedia.org/r/843949

gerritbot added a comment.Oct 18 2022, 7:24 PM

Change 843945 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.4] Remove motd plugin

https://gerrit.wikimedia.org/r/843945

hashar closed this task as Resolved.Oct 18 2022, 7:27 PM
hashar claimed this task.
hashar updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Oct 18 2022, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL