Page MenuHomePhabricator

geoshapes and geomasks are broken when there are duplicate Q items in OSM
Open, Needs TriagePublicBUG REPORT

Description

As reported at: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1117067174#No_boundary_available_for_Livingston,_Louisiana

Steps to replicate the issue (include links if applicable):

  • Have the same Q item listed twice in OSM
    • once as a way
    • once as a relation (a group of ways) containing the previous way
  • Make a geoshape or geomask map on a wiki with this Q item

What happens?:

  • The /geoshape endpoint returns a feature collection with the same shape twice
  • The geoshape when rendered in Kartographer doesn't have fill of the shape, and the geomask doesn't have masking outside the shape or is only masking

What should have happened instead?:

  • An error should be presented in the Kartographer rendering, to warn about the duplicate items
  • OR the shape service should only return 1 Q item

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Weird things like this happen:

osm-intl,12,30.49,-90.7444,290x270@2x.png (540×580 px, 26 KB)

Event Timeline

It looks to me that here too a multi-polygon is improperly built from multiple OSM objects. In case of this geomask example it looks that geometry from one OSM object is used for outer mask area, and identical geometry from another OSM objects gets treated as an inner area, without a cap between the two