Page MenuHomePhabricator
Create Task
Maniphest T321440

MMV doesn't recognize captions of the new <figure> thumbnails
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • wgParserEnableLegacyMediaDOM=false
  • Transclude [[File:Test.jpg|thumb|An example]] on a page
  • Click to open the image in MMV

What happens?:
The title used is "Test"

What should have happened instead?:
The title used should have been: An example
It seems that MMVs findCaption logic does not yet recognize the new style of captions.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Use Parsoid's regularity to find captionmediawiki/extensions/MultimediaViewermaster+12 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Oct 22 2022, 3:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2022, 3:18 PM
TheDJ added a parent task: T51097: Use figure and figcaption HTML5 elements when possible.Oct 22 2022, 3:19 PM
Arlolra claimed this task.Oct 24 2022, 2:21 PM
Arlolra added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).
Restricted Application added a project: Parsoid. · View Herald TranscriptOct 24 2022, 2:21 PM
Arlolra triaged this task as Medium priority.Oct 24 2022, 2:22 PM
Arlolra edited parent tasks, added: T314318: Disable wgParserEnableLegacyMediaDOM on all wikis; removed: T51097: Use figure and figcaption HTML5 elements when possible.
Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.
Arlolra added a comment.Oct 24 2022, 7:34 PM

@TheDJ I wasn't able to reproduce this, can you clarify?

Screen Shot 2022-10-24 at 3.32.45 PM.png (2×2 px, 2 MB)

Screen Shot 2022-10-24 at 3.32.57 PM.png (2×2 px, 3 MB)

TheDJ added a comment.EditedOct 25 2022, 8:16 PM

Ah it's actually more specific than i had figured.

		$potentialCaptions = $thumbContainer.find( '.thumbcaption, figcaption' );
		if ( $potentialCaptions.length < 2 ) {
			$thumbCaption = $potentialCaptions.eq( 0 );
		} else {
			// Template:Multiple_image or some such; try to find closest caption to the image
			// eslint-disable-next-line no-jquery/no-sizzle
			$thumbCaption = $link.closest( ':has(> .thumbcaption)', $thumbContainer )
				.find( '> .thumbcaption' );
		}

It's this condition for multiple_image that fails on this specific fragment of image encapsulated within the caption of another image. Apparently that was also handling nested captions by accident.

[[File:Test.jpg|thumb|An example [[File:Example.svg|100px|right|frameless|Just another example]]]]
gerritbot added a comment.Oct 26 2022, 11:57 PM

Change 849714 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/MultimediaViewer@master] Use Parsoid's regularity to find caption

https://gerrit.wikimedia.org/r/849714

gerritbot added a project: Patch-For-Review.Oct 26 2022, 11:57 PM
Arlolra moved this task from In Progress to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Oct 26 2022, 11:59 PM
SLopes-WMF removed a project: Parsoid.Oct 27 2022, 2:12 PM
Arlolra added a project: Parsoid.Oct 27 2022, 7:37 PM
Arlolra moved this task from Needs Triage to Media Structure on the Parsoid board.
gerritbot added a comment.Oct 27 2022, 8:24 PM

Change 849714 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use Parsoid's regularity to find caption

https://gerrit.wikimedia.org/r/849714

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2022, 8:29 PM
Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Oct 27 2022, 8:29 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 27 2022, 9:00 PM
Arlolra moved this task from To Deploy to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Nov 1 2022, 7:06 PM
Arlolra added a comment.Nov 1 2022, 7:09 PM

https://www.mediawiki.org/w/index.php?title=User:Arlolra/sandbox&oldid=5568472

Arlolra closed this task as Resolved.Nov 1 2022, 7:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits