Page MenuHomePhabricator
Create Task
Maniphest T321747

JS error on Special:EventDetails when a non-organizer tries to use the username filter
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

To reproduce:

  • Log out
  • Go to Special:EventDetails for any event that has participants
  • Enter something in the username search input

Expected: No errors
Actual: The following error appears in the console:

Uncaught TypeError: Cannot read properties of undefined (reading 'setLabel')
    at ParticipantsManager.js.ParticipantsManager.onDeselectAll

Details

SubjectRepoBranchLines +/-
Fix JS error on Special:EventDetailsmediawiki/extensions/CampaignEventsmaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Oct 26 2022, 9:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2022, 9:42 PM
gerritbot added a comment.Oct 26 2022, 9:43 PM

Change 849660 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix JS error on Special:EventDetails

https://gerrit.wikimedia.org/r/849660

gerritbot added a project: Patch-For-Review.Oct 26 2022, 9:43 PM
Daimona claimed this task.Oct 26 2022, 9:43 PM
Daimona set the point value for this task to 0.
Daimona moved this task from Needs Input / Design in progress to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

Discovered this while working on private registration, the fix is trivial.

gerritbot added a comment.Oct 27 2022, 8:32 PM

Change 849660 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix JS error on Special:EventDetails

https://gerrit.wikimedia.org/r/849660

Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 27 2022, 8:32 PM
Daimona removed a project: Patch-For-Review.
Daimona mentioned this in rUCAMf215fb9e5bf7: Fix JS error on Special:EventDetails.Oct 27 2022, 8:32 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 27 2022, 9:00 PM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 28 2022, 4:38 PM
vaughnwalters subscribed.

✅ When logged out and searching for a participant, no errors appear in the console

Screen Recording 2022-10-28 at 11.33.46 AM.gif (1×2 px, 443 KB)

ifried closed this task as Resolved.Nov 1 2022, 8:56 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
ifried subscribed.

This now works as expected (see attached screenshot), so I'm marking this as Done.

Screen Shot 2022-11-01 at 4.55.52 PM.png (1×2 px, 179 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL