Page MenuHomePhabricator
Create Task
Maniphest T322664

IPInfo should return country name translations.
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
• TThoabala
Authored By
• TThoabala
Nov 8 2022, 5:18 PM
Tags
Referenced Files
F36534059: T322664_IPInfo_CountryNameTranslation_it_None.png
Jan 27 2023, 7:17 PM
F36534055: T322664_IPInfo_CountryNameTranslation_pt-BR.png
Jan 27 2023, 7:17 PM
F36534053: T322664_IPInfo_CountryNameTranslation_ES.png
Jan 27 2023, 7:17 PM
Subscribers
Aklapper
ARamirez_WMF
GMikesell-WMF
STran
• TThoabala

Description

Following on T318726, the alternative to removing use of RequestContext::getMain()->getLanguage()->getCode(), is to pass back country name translations from the API to the clients.

AC

  • Remove use of RequestContext::getMain()->getLanguage()->getCode()
  • The fallback chain mechanism is still preserved.
  • Api should Pass back country names to the client.

Details

SubjectRepoBranchLines +/-
IPInfo should return country name translationsmediawiki/extensions/IPInfomaster+211 -172
IPInfo should return country name translationsmediawiki/extensions/IPInfomaster+123 -125
Customize query in gerrit

Related Objects

Event Timeline

• TThoabala created this task.Nov 8 2022, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2022, 5:18 PM
• TThoabala set the point value for this task to 3.Nov 8 2022, 5:19 PM
• TThoabala mentioned this in T318726: Pass context language through to IPInfo API.Nov 8 2022, 5:22 PM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.Nov 8 2022, 5:26 PM
gerritbot added a comment.Nov 10 2022, 11:08 AM

Change 855533 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] IPInfo should return country name translations

https://gerrit.wikimedia.org/r/855533

gerritbot added a project: Patch-For-Review.Nov 10 2022, 11:08 AM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.Nov 14 2022, 4:20 AM
ARamirez_WMF edited projects, added Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat); removed Anti-Harassment (AHaT Sprint 19: The Sanbenito).Nov 22 2022, 6:25 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.
• AGueyte moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.Nov 23 2022, 2:45 PM
• Prtksxna moved this task from Backlog to In Progress on the IP Info board.Nov 28 2022, 3:59 PM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.Dec 5 2022, 8:08 AM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 22: Asian Conical Hat); removed Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat).Dec 6 2022, 3:52 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.
ARamirez_WMF added subscribers: STran, ARamirez_WMF.Dec 6 2022, 6:47 PM

@STran please have another look

• TThoabala moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 14 2022, 7:30 AM
gerritbot added a comment.Jan 3 2023, 7:00 AM

Change 874695 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] IPInfo should return country name translations

https://gerrit.wikimedia.org/r/874695

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Jan 5 2023, 5:05 AM
gerritbot added a comment.Jan 5 2023, 5:14 AM

Change 855533 abandoned by TsepoThoabala:

[mediawiki/extensions/IPInfo@master] IPInfo should return country name translations

Reason:

new patch on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/874695

https://gerrit.wikimedia.org/r/855533

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat); removed Anti-Harassment (AHaT Sprint 22: Asian Conical Hat).Jan 17 2023, 6:06 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.
• TThoabala mentioned this in T327737: Use MaxMind translations in location data.Jan 24 2023, 4:02 AM

Added this ticket https://phabricator.wikimedia.org/T327737 as requested from code review.

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 25 2023, 5:18 PM
gerritbot added a comment.Jan 25 2023, 5:36 PM

Change 874695 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IPInfo should return country name translations

https://gerrit.wikimedia.org/r/874695

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2023, 6:31 PM
GMikesell-WMF subscribed.Jan 27 2023, 7:17 PM

@TThoabala Validated all the languages in countryNames as seen in a couple of the screenshots with each language matching within the IPInfo. Also validated a language that was not in countryNames, which defaulted to English. Thanks!

OS: macOS 13.0
Browser: Chrome 109
Environment: Local
IP test used: 2001:240::
Languages tested: "countryNames":{"de":"Japan","en":"Japan","es":"Japón","fr":"Japon","ja":"日本","pt-BR":"Japão","ru":"Япония","zh-CN":"日本"} and "it" for the language not included to test the default.

Languages in countryNames

T322664_IPInfo_CountryNameTranslation_ES.png (1×3 px, 410 KB)

T322664_IPInfo_CountryNameTranslation_pt-BR.png (1×3 px, 372 KB)

Language NOT in countryNames

T322664_IPInfo_CountryNameTranslation_it_None.png (1×3 px, 349 KB)

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 27 2023, 7:18 PM
• Niharika closed this task as Resolved.Feb 28 2023, 6:28 PM
Dreamy_Jazz moved this task from In Progress to Closed on the IP Info board.Feb 3 2024, 12:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL