Task breakdown notes

• Serialization:
  • DataValue serialization is done in the PropertyValuePairSerializer
• Deserialization:
  • DataValue deserialization is done by a DataValueDeserializer that's passed into the PropertyValuePairDeserializer
  • No need to handle time and globecoordinate differently as the simplification only removes optional/deprecated fields that the DataValueDeserializer doesn't need
  • wikibase-entityid needs to be converted from a string id (e.g. Q123) to an EntityIdValue to pass into PropertyValueSnak

Tasks

Simplify the value format in serializers - @Silvan_WMDE

• Get the DataValue type from the Snak
• If the DataValue type is one of wikibase-entityid, time, or globecoordinate:
  • alter the serialized format returned from DataValue::getArrayValue() according to the story description

T323702: 🍰 Simplify the value format in deserializers

• if the DataValue type is wikibase-entityid:
  • use the EntityIdParser (that's already passed into PropertyValuePairDeserializer) to create an EntityId
  • create a new EntityIdValue from the EntityId
  • create the PropertyValueSnak from the property id and the EntityIdValue
  • return the PropertyValueSnak

@WMDE-leszek is it correct to assume that before, after and timezonemust be set to 0 when creating the TimeValue, since they are no longer provided in the request input?

In T322734#8420081, @Silvan_WMDE wrote:

@WMDE-leszek is it correct to assume that before, after and timezonemust be set to 0 when creating the TimeValue, since they are no longer provided in the request input?

I believe TimeValue `is an implementation concept so I shall not define how it should behave -- but I will answer a slightly different question: In places (e.g. persistence) where those now not-to-be-shown fields are actually stored, their values should use current "default".
This seems to be 0 for time's before, after and timezone, and null for coordinate's altitude

Looks good, thank you!