Page MenuHomePhabricator
Create Task
Maniphest T323704

Eslint: Error out when warnings exist
Closed, ResolvedPublic
Actions

Description

We have a lot of warnings (79) in the console when we run npm test. Let's configure eslint to error out on warnings (max-warnings: 0) and fix the warnings.

Details

SubjectRepoBranchLines +/-
eslint: Error on warningsmediawiki/extensions/GrowthExperimentsmaster+2 -1
NoEditsDisplay: Fix eslint warningsmediawiki/extensions/GrowthExperimentsmaster+2 -1
eslint: Fix JSDoc warningsmediawiki/extensions/GrowthExperimentsmaster+2 -1
eslint: Fix max-len issues in test filesmediawiki/extensions/GrowthExperimentsmaster+6 -3
eslint: Silence more compat/compat warningsmediawiki/extensions/GrowthExperimentsmaster+3 -0
eslint: Fix vue/require-explicit-emits warningsmediawiki/extensions/GrowthExperimentsmaster+2 -0
eslint: Silence more compat/compat warningsmediawiki/extensions/GrowthExperimentsmaster+3 -0
eslint: Increase max-len to 120 for Vue filesmediawiki/extensions/GrowthExperimentsmaster+55 -17
eslint: Silence compat/compat warningsmediawiki/extensions/GrowthExperimentsmaster+5 -0
eslint: Remove unneeded suppressionmediawiki/extensions/GrowthExperimentsmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Nov 23 2022, 1:36 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 23 2022, 1:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Nov 23 2022, 1:37 PM

Change 860025 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Remove unneeded suppression

https://gerrit.wikimedia.org/r/860025

gerritbot added a project: Patch-For-Review.Nov 23 2022, 1:37 PM

Change 860046 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix compat/compat and Vue warnings

https://gerrit.wikimedia.org/r/860046

gerritbot added a comment.Nov 23 2022, 1:37 PM

Change 860020 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Don't allow warnings

https://gerrit.wikimedia.org/r/860020

kostajh added a parent task: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.Nov 23 2022, 1:37 PM
kostajh edited parent tasks, added: T320744: [Epic] Q2 FY 2022-23 Growth Maintenance Work; removed: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.
gerritbot added a comment.Nov 23 2022, 4:28 PM

Change 860025 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Remove unneeded suppression

https://gerrit.wikimedia.org/r/860025

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 23 2022, 5:01 PM
kostajh claimed this task.Dec 7 2022, 12:27 PM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, Growth-Team.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 13 2022, 10:03 AM

Change 867530 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Increase max-len to 120 for Vue files

https://gerrit.wikimedia.org/r/867530

gerritbot added a project: Patch-For-Review.Dec 13 2022, 10:03 AM
gerritbot added a comment.Dec 13 2022, 10:58 AM

Change 867539 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix vue/require-explicit-emits warnings

https://gerrit.wikimedia.org/r/867539

gerritbot added a comment.Dec 13 2022, 10:59 AM

Change 867540 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Silence more compat/compat warnings

https://gerrit.wikimedia.org/r/867540

gerritbot added a comment.Dec 13 2022, 12:17 PM

Change 867569 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix max-len issues in test files

https://gerrit.wikimedia.org/r/867569

gerritbot added a comment.Dec 13 2022, 6:52 PM

Change 860046 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Silence compat/compat warnings

https://gerrit.wikimedia.org/r/860046

gerritbot added a comment.Dec 13 2022, 6:53 PM

Change 867530 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Increase max-len to 120 for Vue files

https://gerrit.wikimedia.org/r/867530

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 13 2022, 7:00 PM
gerritbot added a comment.Dec 14 2022, 9:45 AM

Change 867539 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix vue/require-explicit-emits warnings

https://gerrit.wikimedia.org/r/867539

gerritbot added a comment.Dec 14 2022, 9:50 AM

Change 867540 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] eslint: Silence more compat/compat warnings

Reason:

https://gerrit.wikimedia.org/r/867540

gerritbot added a comment.Dec 14 2022, 9:52 AM

Change 868031 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Silence more compat/compat warnings

https://gerrit.wikimedia.org/r/868031

gerritbot added a comment.Dec 14 2022, 9:53 AM

Change 868032 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix JSDoc warnings

https://gerrit.wikimedia.org/r/868032

gerritbot added a comment.Dec 14 2022, 10:55 AM

Change 868031 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Silence more compat/compat warnings

https://gerrit.wikimedia.org/r/868031

gerritbot added a comment.Dec 14 2022, 10:55 AM

Change 867569 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix max-len issues in test files

https://gerrit.wikimedia.org/r/867569

gerritbot added a comment.Dec 14 2022, 11:11 AM

Change 868032 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix JSDoc warnings

https://gerrit.wikimedia.org/r/868032

gerritbot added a comment.Dec 14 2022, 11:16 AM

Change 868042 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NoEditsDisplay: Fix eslint warnings

https://gerrit.wikimedia.org/r/868042

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 14 2022, 11:17 AM
gerritbot added a comment.Dec 14 2022, 11:37 AM

Change 868042 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NoEditsDisplay: Fix eslint warnings

https://gerrit.wikimedia.org/r/868042

gerritbot added a comment.Dec 14 2022, 11:37 AM

Change 860020 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Error on warnings

https://gerrit.wikimedia.org/r/860020

kostajh closed this task as Resolved.Dec 19 2022, 2:05 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
MShilova_WMF removed a subtask: T325082: Eslint: configure browser compatibility.Jan 5 2023, 6:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits