Page MenuHomePhabricator

Eslint: Error out when warnings exist
Open, Needs TriagePublic

Description

We have a lot of warnings (79) in the console when we run npm test. Let's configure eslint to error out on warnings (max-warnings: 0) and fix the warnings.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 860025 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Remove unneeded suppression

https://gerrit.wikimedia.org/r/860025

Change 860046 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Fix compat/compat and Vue warnings

https://gerrit.wikimedia.org/r/860046

Change 860020 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] eslint: Don't allow warnings

https://gerrit.wikimedia.org/r/860020

Change 860025 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] eslint: Remove unneeded suppression

https://gerrit.wikimedia.org/r/860025