Eslint: configure browser compatibility
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sgs
	Dec 13 2022, 5:27 PM

Description

We are constraining the client module browser compatibility in modules using Vue (3) since the framework does not support IE11 and other older browsers. It would be nice to configure eslint compatibility rules (compat/compat) accordingly. This way we can avoid having to manually override use cases with // eslint-disable-next-line compat/compat

Also making ES6 modules identifiable via URL structure per comments in patch.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	chore(eslint): make compat rule into errors again	mediawiki/extensions/GrowthExperiments	master	+3 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Resolved	DMburugu	T367429 [Epic] FY 2024-25 Growth Maintenance Work
Resolved	Michael	T325082 Eslint: configure browser compatibility

Event Timeline

Sgs created this task.Dec 13 2022, 5:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2022, 5:27 PM

Sgs updated the task description. (Show Details)Dec 13 2022, 5:28 PM

kostajh awarded a token.Dec 19 2022, 2:05 PM

MShilova_WMF added a parent task: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.Jan 5 2023, 6:28 PM

MShilova_WMF removed a parent task: T323704: Eslint: Error out when warnings exist.Jan 5 2023, 6:33 PM

DMburugu added a parent task: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Jan 11 2023, 4:54 PM

DMburugu moved this task from Sprint 0 (Growth Team) to Triaged on the Growth-Team board.Jan 11 2023, 5:07 PM

DMburugu edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).

DMburugu moved this task from Triaged to Current Maintenance Focus on the Growth-Team board.Jan 31 2023, 3:23 PM

DMburugu triaged this task as Low priority.Feb 27 2023, 1:21 PM

DMburugu moved this task from Current Maintenance Focus to Sprint 0 (Growth Team) on the Growth-Team board.

DMburugu edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

DMburugu moved this task from Incoming to Current Month Maintenance Priorities on the Growth-Team (Sprint 0 (Growth Team)) board.

DMburugu edited parent tasks, added: T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work; removed: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.Mar 28 2023, 12:18 PM

DMburugu edited parent tasks, added: T340455: [Epic] Q1 FY 2023-24 Growth Maintenance Work, T340453: [Epic] FY 2023-24 Growth Maintenance Work; removed: T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work, T311850: [Epic] FY 2022-23 Growth Maintenance Work.Jun 26 2023, 5:06 PM

DMburugu removed a parent task: T340455: [Epic] Q1 FY 2023-24 Growth Maintenance Work.Oct 2 2023, 10:14 AM

DMburugu removed a project: Growth-Team (Sprint 0 (Growth Team)).Oct 6 2023, 8:41 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 6 2023, 8:41 AM

JFernandez-WMF moved this task from Inbox to Current Maintenance Focus on the Growth-Team board.Jan 23 2024, 9:59 AM

DMburugu added a subtask: T367429: [Epic] FY 2024-25 Growth Maintenance Work.Jun 18 2024, 12:39 PM

Urbanecm_WMF edited projects, added Growth-Team (Maintenance); removed Growth-Team.Nov 18 2024, 5:24 PM

Sgs moved this task from Backlog to GrowthExperiments dark mode on the Growth-Team (Maintenance) board.Nov 19 2024, 12:10 PM

Sgs moved this task from GrowthExperiments dark mode to Backlog on the Growth-Team (Maintenance) board.Nov 20 2024, 3:41 PM

Change #1125987 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] chore(eslint): make compat rule into errors again

https://gerrit.wikimedia.org/r/1125987

gerritbot added a project: Patch-For-Review.Mar 10 2025, 10:57 AM

Michael removed a subtask: T367429: [Epic] FY 2024-25 Growth Maintenance Work.Mar 10 2025, 10:58 AM

Michael added a parent task: T367429: [Epic] FY 2024-25 Growth Maintenance Work.

Michael edited projects, added Growth-Team (Current Sprint); removed Growth-Team (Maintenance).Mar 10 2025, 11:26 AM

The upstream browser compatibility has been updated a while ago to no longer include IE 11. So this just needed some minor cleanup and then it can be closed. Raising the compatibility threshold further is being discussed in T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Michael claimed this task.Mar 10 2025, 11:34 AM

Restricted Application added a project: User-Michael. · View Herald TranscriptMar 10 2025, 11:34 AM

Change #1125987 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] chore(eslint): make compat rule into errors again

https://gerrit.wikimedia.org/r/1125987