Page MenuHomePhabricator

Add RTL support on dialog transitions
Closed, ResolvedPublic

Description

Transitions between steps in the Vue Onboarding dialog are not adapting to directional changes in RTL

Event Timeline

Change 912774 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: add RTL support to transitions in OnboardingDialog

https://gerrit.wikimedia.org/r/912774

Change 912774 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: add RTL support to transitions in OnboardingDialog

https://gerrit.wikimedia.org/r/912774

Sgs changed the task status from Open to In Progress.May 15 2023, 10:08 AM
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Looking at the latest demo there seems to be something off in the paginator text. cc @VYanez-WMF

Screenshot 2023-05-15 at 12.07.29.png (1×1 px, 185 KB)

Maybe we could add the translations from some RTL language like Arabic to make the demos more realistic and help us testing.

Sgs changed the task status from In Progress to Open.May 15 2023, 10:27 AM
Sgs moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Yes, noticed that. I wonder if it is related to the character directionality strong, weak or neutral types because if using a RTL lang it seems to be showing the correct direction, so I am not sure which changes we should introduce.

Screenshot 2023-05-15 at 13.00.38.png (1×1 px, 142 KB)
Screenshot 2023-05-15 at 13.00.18.png (1×1 px, 135 KB)

Ops, you are right, this shouldn't happen in MW production.

Change 922824 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: refactor RTL handling in MultiPane to reuse codex composable

https://gerrit.wikimedia.org/r/922824

Sgs changed the task status from Open to In Progress.May 24 2023, 1:05 PM
Sgs claimed this task.

Change 922824 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: refactor RTL handling in MultiPane

https://gerrit.wikimedia.org/r/922824