In order to facilitate testing and catching regressions it would be handy to have a flag to enable/disable the Vue version of the on-boarding dialog(s). eg ?use-vue.
Acceptance criteria
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Help panel: add feature flag for using Vue dialogs | Viviana Yanez | mediawiki/extensions/GrowthExperiments | master | +30 -16 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | DMburugu | T367429 [Epic] FY 2024-25 Growth Maintenance Work | |||
| Open | Sgs | T296646 [Epic] Migration of front-end modules to Vue.js components | |||
| Resolved | KStoller-WMF | T329033 [Internship] Modernization of web interfaces using Vue.js | |||
| Open | None | T329037 Refactor the "Add a link" on-boarding dialog to Vue | |||
| Open | None | T331986 Integrate the Vue version of the Add a link on-boarding in GrowthExperiments | |||
| Open | None | T335568 Create a flag/param to switch on/off the Vue version |
Change 928794 had a related patch set uploaded (by Viviana Yanez; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] WIP Help panel: add feature flag for using Vue dialogs
Change 928794 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: add feature flag for using Vue dialogs
This issue can be tested by using ?new-onboarding=0 or ?new-onboarding=1 on Special:Homepage
Note that the error 'Cannot read properties of undefined (reading 'openWindow')' when using ?new-onboarding=1 will be fixed on https://phabricator.wikimedia.org/T331986
Removing inactive task assignee who's not with WMF anymore. (WMF Growth-Team: Please do so as part of team offboarding steps - thanks.)
@Sgs - following the instructions in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/928794/
To display the Vue version of the Add a link dialog either:
- right click on a task card from Special:Homepage, copy the URL and modify it to add &new-onboarding=1, paste the >updated URL into the browser URL bar
The onboarding won't be displayed, e.g. https://cs.wikipedia.beta.wmflabs.org/w/index.php?title=Yavanna&gesuggestededit=1&new-onboarding=1&veaction=edit
- or visit Special:Homepage?new-onboarding=1
From https://en.wikipedia.beta.wmflabs.org/wiki/Special:Homepage?new-onboarding=1 clicking on add link structured task will redirect to an article where
For add image tasks, the onboarding wouldn't be displayed (no errors in the Console).
@Sgs - should we move this back to unstarted / Ready for development? Or do we want to resolve this task and create a follow up task for any further work that might be needed?
@Sgs I think the onboarding is no longer new and the Vue version is now the standard? Is there some cleanup that still needs doing to remove the OOUI version or can we just close this task?