Page MenuHomePhabricator

ComputedUserImpactLookup: PHP Warning: Invalid argument supplied for foreach()
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Warning: Invalid argument supplied for foreach()
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.15/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(393)
#0 /srv/mediawiki/php-1.41.0-wmf.15/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(393): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.41.0-wmf.15/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(184): GrowthExperiments\UserImpact\ComputedUserImpactLookup->getPageViewData(User, array, array, integer)
#2 /srv/mediawiki/php-1.41.0-wmf.15/extensions/GrowthExperiments/includes/Rest/Handler/UserImpactHandler.php(123): GrowthExperiments\UserImpact\ComputedUserImpactLookup->getExpensiveUserImpact(User)
#3 /srv/mediawiki/php-1.41.0-wmf.15/extensions/GrowthExperiments/includes/Rest/Handler/UserImpactHandler.php(68): GrowthExperiments\Rest\Handler\UserImpactHandler->getUserImpact(MediaWiki\User\UserIdentityValue)
#4 /srv/mediawiki/php-1.41.0-wmf.15/includes/Rest/SimpleHandler.php(38): GrowthExperiments\Rest\Handler\UserImpactHandler->run(MediaWiki\User\UserIdentityValue)
#5 /srv/mediawiki/php-1.41.0-wmf.15/includes/Rest/Router.php(517): MediaWiki\Rest\SimpleHandler->execute()
#6 /srv/mediawiki/php-1.41.0-wmf.15/includes/Rest/Router.php(422): MediaWiki\Rest\Router->executeHandler(GrowthExperiments\Rest\Handler\UserImpactHandler)
#7 /srv/mediawiki/php-1.41.0-wmf.15/includes/Rest/EntryPoint.php(195): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#8 /srv/mediawiki/php-1.41.0-wmf.15/includes/Rest/EntryPoint.php(135): MediaWiki\Rest\EntryPoint->execute()
#9 /srv/mediawiki/php-1.41.0-wmf.15/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#10 /srv/mediawiki/w/rest.php(3): require(string)
#11 {main}
Impact

Unclear.

Notes

Noted a few of these on testwiki after staging of 1.41.0-wmf.15 train (T340243). May block if volume is noticeable at group0.

Details

Request URL
https://test.wikipedia.org/w/rest.php/growthexperiments/v0/user-impact/%2334042?lang=*

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Looks like a mishandled null return. We didn't make any changes to that code recently, I doubt it's train-related.

Change 935819 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] New impact: Fix ComputedUserImpactLookup::getPageViewData* return types

https://gerrit.wikimedia.org/r/935819

Change 935819 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] New impact: Fix ComputedUserImpactLookup::getPageViewData* return types

https://gerrit.wikimedia.org/r/935819

Etonkovidova subscribed.

No reports for wmf.17 (the last timestamp for the error - Jul 7, 2023 @ 14:58:03.873 logstash link).