Page MenuHomePhabricator
Create Task
Maniphest T340243

1.41.0-wmf.15 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.41.0-wmf.15
Release Date
Jun 26 2023, 12:00 AM

2023 week 26 1.41-wmf.15 Changes wmf/1.41.0-wmf.15

This MediaWiki Train Deployment is scheduled for the week of Monday, June 26th:

Monday June 26thTuesday, June 27thWednesday, June 28thThursday, June 29thFriday
Backports only.Branch wmf.15 and deploy to Group 0 Wikis.Deploy wmf.15 to Group 1 Wikis.Deploy wmf.15 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.15 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.14
Next: 1.41.0-wmf.16
SubjectRepoBranchLines +/-
group2 wikis to 1.41.0-wmf.15operations/mediawiki-configmaster+327 -327
group1 wikis to 1.41.0-wmf.15operations/mediawiki-configmaster+544 -544
group0 wikis to 1.41.0-wmf.15operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.41.0-wmf.15operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.15mediawiki/corewmf/1.41.0-wmf.15+986 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jun 23 2023, 6:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2023, 6:57 PM
Jdforrester-WMF added a subtask: T315036: Unexpected "In other languages" section in Vector 22 sidebar.Jun 23 2023, 6:59 PM
Jdforrester-WMF added subscribers: matmarex, Jdforrester-WMF.
In T337528#8933271, @matmarex wrote:

For the next week's train (I don't think there's a task yet):

Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/925125 "SpecialLog: Enable built-in validation of HTMLForm" (T338042)
  • Summary: Special:Log is a very old and stable interface. It's possible that someone or something relies on the buggy lack of validation.
  • Test plan: Tested manually.
  • Places to monitor: Bug reports mentioning Special:Log (issues are unlikely to result in any automated error logging)
  • Revert plan: Revert patch
  • Affected wikis: all
  • IRC contact: MatmaRex
  • UBN Task Projects/tags: MediaWiki-General
  • Would you like to backport this change rather than ride the train?: No
thcipriani assigned this task to brennen.Jun 23 2023, 7:09 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Func subscribed.Jun 23 2023, 7:22 PM
Jdlrobson subscribed.EditedJun 26 2023, 11:41 PM
  1. Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/929795
  • Summary:There is a risk of an increased level of warnings in the new train related to legacy use of the targets system in extensions which do not have unit tests that run on core patches I've just noticed. The log message will show as "Modules must target desktop and mobile. Module name: <name of module>" https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/933186/1 for example. The fix to modules it occurs on are pretty simple and I'd prefer to fix them based on volume of errors unless there is an exceptional amount of them and strong reasons why they can't be fixed.
  • Test plan: Logstash (beta) doesn't show any issues, but I don't trust it's setup correctly. We should check the deprecated channel after the group 0 deploy for a better sense.
  • Places to monitor: https://logstash.wikimedia.org/app/dashboards#/view/mediawiki-deprecated
  • Revert plan: Reverting core patch should be safe but ideally after patching the appropriate extensions has been ruled out for some reason (And ideally after IRC contacts have OKed it). If reverted please make sure the task for impacted extensions stays open and make it blocker of the next deploy as it's important this change rolls out sooner rather than later.
  • Affected wikis: all
  • Phab contact: Jdlrobson, Catrope
  • UBN Task Projects/tags: Please use the component tag. E.g. for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/933186 please tag Citoid pointing to this message.
  • Would you like to backport this change rather than ride the train?: No
Jdlrobson mentioned this in T340499: PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.citoid.wikibase.init was deprecated in MediaWiki 1.41. .Jun 26 2023, 11:46 PM
gerritbot added a comment.Jun 27 2023, 2:07 AM

Change 932814 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.15] Branch commit for wmf/1.41.0-wmf.15

https://gerrit.wikimedia.org/r/932814

gerritbot added a project: Patch-For-Review.Jun 27 2023, 2:07 AM
gerritbot added a comment.Jun 27 2023, 2:27 AM

Change 932814 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.15] Branch commit for wmf/1.41.0-wmf.15

https://gerrit.wikimedia.org/r/932814

hashar added a subtask: T250720: CVE-2023-37301: Wikidata edit filter does not fire when test tool says it should.Jun 27 2023, 4:55 AM
gerritbot added a comment.Jun 27 2023, 4:35 PM

Change 933500 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/933500

Stashbot added a comment.Jun 27 2023, 4:36 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T16:36:20Z] <brennen> train 1.41.0-wmf.15: re-running scap stage-train (T340243)

gerritbot added a comment.Jun 27 2023, 4:36 PM

Change 933500 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/933500

Stashbot added a comment.Jun 27 2023, 4:37 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T16:37:11Z] <brennen@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.15 refs T340243

brennen added a project: User-brennen.Jun 27 2023, 4:38 PM
Stashbot added a comment.Jun 27 2023, 5:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T17:20:07Z] <brennen@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.15 refs T340243 (duration: 42m 56s)

brennen mentioned this in T340564: ComputedUserImpactLookup: PHP Warning: Invalid argument supplied for foreach().Jun 27 2023, 5:41 PM
brennen mentioned this in T340565: PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.gadget.mobileonlygadget was deprecated in MediaWiki 1.41..Jun 27 2023, 5:49 PM
brennen removed a subtask: T250720: CVE-2023-37301: Wikidata edit filter does not fire when test tool says it should.Jun 27 2023, 5:58 PM
Daimona subscribed.Jun 27 2023, 6:05 PM
brennen removed a subtask: T315036: Unexpected "In other languages" section in Vector 22 sidebar.Jun 27 2023, 6:05 PM
gerritbot added a comment.Jun 27 2023, 6:33 PM

Change 933610 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/933610

gerritbot added a comment.Jun 27 2023, 6:34 PM

Change 933610 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/933610

Stashbot added a comment.Jun 27 2023, 6:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T18:41:16Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.15 refs T340243

brennen mentioned this in T340567: TypeError: Argument 1 passed to MediaWiki\Extension\Gadgets\Gadget::__construct() must be of the type array, object given.Jun 27 2023, 6:42 PM
brennen mentioned this in T340568: Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: Property Simplify.Jun 27 2023, 6:48 PM
brennen added a subtask: T340499: PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.citoid.wikibase.init was deprecated in MediaWiki 1.41. .Jun 27 2023, 6:51 PM
brennen closed subtask T340499: PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.citoid.wikibase.init was deprecated in MediaWiki 1.41. as Resolved.Jun 27 2023, 7:34 PM
matmarex added a subtask: T340568: Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: Property Simplify.Jun 27 2023, 7:48 PM
matmarex closed subtask T340568: Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: Property Simplify as Resolved.Jun 27 2023, 9:30 PM
brennen added a comment.Jun 28 2023, 4:57 PM

Pre-emptively noting that I have a hard stop today at 16:45 MDT / 22:45 UTC, and RelEng is a bit short-staffed this week. In the event of a blocker that's unresolved before 16:00 local, I am likely to pause the train overnight.

Stashbot added a comment.Jun 28 2023, 6:02 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-28T18:02:03Z] <brennen> train 1.41.0-wmf.15 (T340243): no current blockers, rolling to group1.

gerritbot added a comment.Jun 28 2023, 6:06 PM

Change 933987 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/933987

gerritbot added a comment.Jun 28 2023, 6:07 PM

Change 933987 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/933987

Stashbot added a comment.Jun 28 2023, 6:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-28T18:14:37Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.15 refs T340243

brennen mentioned this in T340679: PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.wikisource.OCR was deprecated in MediaWiki 1.41..Jun 28 2023, 6:17 PM
Stashbot added a comment.Jun 28 2023, 6:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-28T18:20:56Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.15 refs T340243 (duration: 06m 18s)

brennen mentioned this in T340682: Large set of Gadgets "PHP Deprecated: Use of Modules must target desktop and mobile." after deployment of 1.41.0-wmf.15 to group1.Jun 28 2023, 6:29 PM
brennen reopened subtask T340568: Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: Property Simplify as Open.Jun 28 2023, 6:50 PM
brennen added a comment.Jun 28 2023, 7:10 PM

T340679 and T340682 are at enough volume that I'd like to see them fixed before going to all wikis.

Stashbot added a comment.Jun 28 2023, 7:46 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-28T19:46:54Z] <brennen> train 1.41.0-wmf.15 (T340243): deploying a revert for T127268 related deprecation logspam - this is likely to impinge on upcoming backport window, which currently has no patches. will update when finished.

Stashbot mentioned this in T127268: Dismantle ResourceLoader's "targets" system.Jun 28 2023, 7:46 PM
Reedy added a subtask: T340740: Precondition failed: This Title instance does not represent an existing page.Jun 29 2023, 12:38 PM
matmarex closed subtask T340568: Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: Property Simplify as Resolved.Jun 29 2023, 2:09 PM
matmarex added a subtask: T340757: "Insert → Basic reference" / "Cite → Manual → Basic" does not work, throws error.Jun 29 2023, 3:18 PM
matmarex closed subtask T340757: "Insert → Basic reference" / "Cite → Manual → Basic" does not work, throws error as Resolved.Jun 29 2023, 5:47 PM
Stashbot added a comment.Jun 29 2023, 6:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-29T18:06:41Z] <brennen> train 1.41.0-wmf.15 (T340243): no current blockers, logs calm, rolling to all wikis

gerritbot added a comment.Jun 29 2023, 6:07 PM

Change 934397 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/934397

gerritbot added a comment.Jun 29 2023, 6:09 PM

Change 934397 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.15

https://gerrit.wikimedia.org/r/934397

Stashbot added a comment.Jun 29 2023, 6:16 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-29T18:16:40Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.15 refs T340243

brennen mentioned this in T340781: InfoAction: PHP Notice: Undefined index: subpages.Jun 29 2023, 6:30 PM
brennen moved this task from Backlog to Doing on the User-brennen board.Jun 29 2023, 6:33 PM
TheDJ subscribed.Jun 30 2023, 10:58 AM

It seems I introduced a video playback bug with T340816: Unable to load media player on mobile devices. I'll schedule a back port of the fix for Monday.

brennen added a comment.Jun 30 2023, 5:55 PM

It seems I introduced a video playback bug with T340816: Unable to load media player on mobile devices. I'll schedule a back port of the fix for Monday.

This seems like it warrants a Friday deploy. Would have been considered a blocker if it were caught earlier in the week, I'd think.

brennen closed this task as Resolved.Jun 30 2023, 6:27 PM
brennen moved this task from Doing to Done or Declined on the User-brennen board.

Deployed fix for T340816. Otherwise looks stable on all wikis.

Peachey88 reopened this task as Open.Jul 1 2023, 3:58 AM
Peachey88 added a subtask: T340821: Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versions.
Peachey88 subscribed.

Looks to be a issue with file deletions, deleting more than expected: T340821: Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versions

Novem_Linguae closed subtask T340821: Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versions as Resolved.Jul 1 2023, 8:27 AM
hashar closed this task as Resolved.Jul 1 2023, 8:31 AM
hashar subscribed.

Remarking as resolved after T340821 got fixed this morning.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL