Page MenuHomePhabricator
Create Task
Maniphest T340679

PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.wikisource.OCR was deprecated in MediaWiki 1.41.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.wikisource.OCR was deprecated in MediaWiki 1.41. [Called from MediaWiki\ResourceLoader\StartUpModule::getScript]
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/StartUpModule.php(420)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.41.0-wmf.15/includes/debug/MWDebug.php(382): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.41.0-wmf.15/includes/debug/MWDebug.php(353): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.41.0-wmf.15/includes/debug/MWDebug.php(234): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.41.0-wmf.15/includes/GlobalFunctions.php(774): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/StartUpModule.php(195): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/StartUpModule.php(420): MediaWiki\ResourceLoader\StartUpModule->getModuleRegistrations(MediaWiki\ResourceLoader\Context)
#7 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/Module.php(816): MediaWiki\ResourceLoader\StartUpModule->getScript(MediaWiki\ResourceLoader\Context)
#8 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/Module.php(785): MediaWiki\ResourceLoader\Module->buildContent(MediaWiki\ResourceLoader\Context)
#9 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/Module.php(925): MediaWiki\ResourceLoader\Module->getModuleContent(MediaWiki\ResourceLoader\Context)
#10 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/ResourceLoader.php(687): MediaWiki\ResourceLoader\Module->getVersionHash(MediaWiki\ResourceLoader\Context)
#11 [internal function]: MediaWiki\ResourceLoader\ResourceLoader->MediaWiki\ResourceLoader\{closure}(string)
#12 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/ResourceLoader.php(685): array_map(Closure, array)
#13 /srv/mediawiki/php-1.41.0-wmf.15/includes/ResourceLoader/ResourceLoader.php(786): MediaWiki\ResourceLoader\ResourceLoader->getCombinedVersion(MediaWiki\ResourceLoader\Context, array)
#14 /srv/mediawiki/php-1.41.0-wmf.15/load.php(53): MediaWiki\ResourceLoader\ResourceLoader->respond(MediaWiki\ResourceLoader\Context)
#15 /srv/mediawiki/php-1.41.0-wmf.15/load.php(39): wfLoadMain()
#16 /srv/mediawiki/w/load.php(3): require(string)
#17 {main}
Impact
Notes

Filing per T340243#8966056. Unsure about tags.

Details

Request URL
https://ht.wikisource.org/w/load.php?lang=*&modules=*&only=*&raw=*&safemode=*&skin=*&target=*
SubjectRepoBranchLines +/-
Load OCR code on editor page on mobile as well as desktopmediawiki/extensions/Wikisourcewmf/1.41.0-wmf.15+2 -1
Load OCR code on editor page on mobile as well as desktopmediawiki/extensions/Wikisourcemaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

brennen created this task.Jun 28 2023, 6:17 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptJun 28 2023, 6:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
brennen mentioned this in T340243: 1.41.0-wmf.15 deployment blockers.Jun 28 2023, 7:10 PM
gerritbot added a comment.Jun 28 2023, 7:17 PM

Change 933991 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikisource@master] Load OCR code on editor page

https://gerrit.wikimedia.org/r/933991

gerritbot added a project: Patch-For-Review.Jun 28 2023, 7:17 PM
gerritbot added a comment.Jun 28 2023, 7:52 PM

Change 933991 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Load OCR code on editor page on mobile as well as desktop

https://gerrit.wikimedia.org/r/933991

gerritbot added a comment.Jun 28 2023, 7:55 PM

Change 933643 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikisource@wmf/1.41.0-wmf.15] Load OCR code on editor page on mobile as well as desktop

https://gerrit.wikimedia.org/r/933643

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 28 2023, 8:00 PM
Jdlrobson closed this task as Resolved.Jun 28 2023, 8:37 PM
Jdlrobson claimed this task.
Jdlrobson edited projects, added All-and-every-Wikisource; removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).

We've disabled the logging for this week's train so no need to backport.

gerritbot added a comment.Jun 28 2023, 8:37 PM

Change 933643 abandoned by Jdlrobson:

[mediawiki/extensions/Wikisource@wmf/1.41.0-wmf.15] Load OCR code on editor page on mobile as well as desktop

Reason:

We backported a patch to disable the logging instead.

https://gerrit.wikimedia.org/r/933643

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2023, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL