Page MenuHomePhabricator
Create Task
Maniphest T340757

"Insert → Basic reference" / "Cite → Manual → Basic" does not work, throws error
Closed, ResolvedPublic
Actions

Description

"Insert → Basic reference" / "Cite → Manual → Basic" does not work, throws error: Uncaught TypeError: list.getItemNode(...) is undefined

Details

SubjectRepoBranchLines +/-
Fix undefined/null confusion in a checkmediawiki/extensions/Citemaster+1 -1
Revert "Add extends warning to reference dialog"mediawiki/extensions/Citemaster+5 -20
Revert "Add extends warning to reference dialog"mediawiki/extensions/Citewmf/1.41.0-wmf.15+5 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jun 29 2023, 3:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2023, 3:18 PM
matmarex added a comment.Jun 29 2023, 3:18 PM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/927192

matmarex added a parent task: T340243: 1.41.0-wmf.15 deployment blockers.Jun 29 2023, 3:18 PM
ppelberg triaged this task as High priority.Jun 29 2023, 3:27 PM
ppelberg added a project: Editing-team (Kanban Board).
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
matmarex claimed this task.Jun 29 2023, 3:30 PM
gerritbot added a comment.Jun 29 2023, 3:32 PM

Change 934369 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Cite@master] Fix undefined/null confusion in a check

https://gerrit.wikimedia.org/r/934369

gerritbot added a project: Patch-For-Review.Jun 29 2023, 3:32 PM
gerritbot added a comment.Jun 29 2023, 3:38 PM

Change 934347 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Revert "Add extends warning to reference dialog"

https://gerrit.wikimedia.org/r/934347

brennen raised the priority of this task from High to Unbreak Now!.Jun 29 2023, 4:20 PM
brennen subscribed.

UBN as train blocker, per policy.

gerritbot added a comment.Jun 29 2023, 4:36 PM

Change 934369 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/Cite@master] Fix undefined/null confusion in a check

Reason:

Looks like we're reverting instead

https://gerrit.wikimedia.org/r/934369

gerritbot added a comment.Jun 29 2023, 4:58 PM

Change 934347 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Revert "Add extends warning to reference dialog"

https://gerrit.wikimedia.org/r/934347

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 29 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 29 2023, 5:10 PM
gerritbot added a comment.Jun 29 2023, 5:11 PM

Change 934350 had a related patch set uploaded (by Bartosz Dziewoński; author: Awight):

[mediawiki/extensions/Cite@wmf/1.41.0-wmf.15] Revert "Add extends warning to reference dialog"

https://gerrit.wikimedia.org/r/934350

gerritbot added a project: Patch-For-Review.Jun 29 2023, 5:11 PM
gerritbot added a comment.Jun 29 2023, 5:34 PM

Change 934350 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.41.0-wmf.15] Revert "Add extends warning to reference dialog"

https://gerrit.wikimedia.org/r/934350

Stashbot added a comment.Jun 29 2023, 5:35 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-29T17:35:00Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:934350|Revert "Add extends warning to reference dialog" (T247922 T340757)]]

Stashbot mentioned this in T247922: Display parent references of subreferences in the VE pop up and wizard.Jun 29 2023, 5:35 PM
Stashbot added a comment.Jun 29 2023, 5:38 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-29T17:38:16Z] <taavi@deploy1002> matmarex and taavi: Backport for [[gerrit:934350|Revert "Add extends warning to reference dialog" (T247922 T340757)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Jun 29 2023, 5:46 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-29T17:46:07Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:934350|Revert "Add extends warning to reference dialog" (T247922 T340757)]] (duration: 11m 06s)

matmarex closed this task as Resolved.Jun 29 2023, 5:47 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 29 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 29 2023, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL