Page MenuHomePhabricator
Create Task
Maniphest T367575

Structured Mentor list should load its data using the CommunityConfiguration extension
Closed, ResolvedPublic
Actions

Description

Right now, the structured mentor list is using the legacy Community Configuration code (as one of the two parts of the extension). While it works, it duplicates virtually equal code in two places: MediaWiki-extensions-CommunityConfiguration and GrowthExperiments. To avoid doing that, we should switch to CommunityConfiguration for structured Mentor list as well.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Validate mentor list using a JSON schemamediawiki/extensions/GrowthExperimentsmaster+97 -27
Mentor list: Respect mentor list change tag with CommunityConfigurationmediawiki/extensions/GrowthExperimentsmaster+10 -2
Mentor list: Support CommunityConfiguration extensionmediawiki/extensions/GrowthExperimentsmaster+184 -18
Make it possible to skip permission checks from the provider levelmediawiki/extensions/CommunityConfigurationmaster+88 -30
Mentor list: Prepare for CommunityConfiguration extensionmediawiki/extensions/GrowthExperimentsmaster+189 -212
IConfigurationStore: Add support for writes without permissionsmediawiki/extensions/CommunityConfigurationmaster+75 -6
WikiPageWriter: Do not use the clone keywordmediawiki/extensions/CommunityConfigurationmaster+18 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Jun 14 2024, 4:04 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 14 2024, 4:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF triaged this task as Medium priority.Jun 14 2024, 4:05 PM
Urbanecm_WMF moved this task from Backlog to [Growth] Needed before all-wikis release on the CommunityConfiguration-Adoption board.

I think we should start on this fairly soon (ideally before all-wikis deployment, although we can delay that if needed), so that we can verify the migrated structured mentorlist works more easily.

Urbanecm_WMF raised the priority of this task from Medium to High.Jun 14 2024, 4:05 PM
Urbanecm_WMF moved this task from Inbox to Backlog on the Growth-Team board.
Urbanecm_WMF added a parent task: T367574: [Epic] Remove code for Special:EditGrowthConfig.Jun 14 2024, 4:13 PM
Urbanecm_WMF mentioned this in T367655: Community configuration: Add support for dynamically-hidden providers.Jun 16 2024, 2:20 PM
Urbanecm_WMF mentioned this in T368728: CommunityConfiguration: skipDashboardListing should fully hide the provider from UI.Jun 28 2024, 1:29 PM
gerritbot added a comment.Jun 28 2024, 2:27 PM

Change #1050621 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentor list: Prepare for CommunityConfiguration extension

https://gerrit.wikimedia.org/r/1050621

gerritbot added a project: Patch-For-Review.Jun 28 2024, 2:27 PM
gerritbot added a comment.Jun 28 2024, 2:48 PM

Change #1050627 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentor list: Support CommunityConfiguration extension

https://gerrit.wikimedia.org/r/1050627

Urbanecm_WMF claimed this task.Jun 28 2024, 2:52 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 17 (Growth Team)); removed Growth-Team.
Urbanecm_WMF mentioned this in T368739: CommunityConfiguration: Allow client extensions to provide their own tag names.Jun 28 2024, 3:00 PM
Urbanecm_WMF added a subtask: T368739: CommunityConfiguration: Allow client extensions to provide their own tag names.
Urbanecm_WMF mentioned this in T368741: CommunityConfiguration's WikiPageStore does not support non-object input.Jun 28 2024, 3:11 PM
Urbanecm_WMF added a subtask: T368741: CommunityConfiguration's WikiPageStore does not support non-object input.
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 17 (Growth Team)) board.Jun 28 2024, 3:34 PM

This is now ready for feedback. It lacks the edit tag capability, which depends on T368739: CommunityConfiguration: Allow client extensions to provide their own tag names.

gerritbot added a comment.Jun 29 2024, 6:18 PM

Change #1050638 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] WikiPageWriter: Do not use the clone keyword

https://gerrit.wikimedia.org/r/1050638

Urbanecm_WMF moved this task from [Growth] Needed before all-wikis release to Backlog on the CommunityConfiguration-Adoption board.Jul 1 2024, 8:29 AM
Urbanecm_WMF lowered the priority of this task from High to Medium.Jul 2 2024, 11:57 AM
gerritbot added a comment.Jul 2 2024, 9:09 PM

Change #1051460 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentor list: Respect mentor list change tag with CommunityConfiguration

https://gerrit.wikimedia.org/r/1051460

gerritbot added a comment.Jul 3 2024, 9:30 AM

Change #1050638 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] WikiPageWriter: Do not use the clone keyword

https://gerrit.wikimedia.org/r/1050638

Urbanecm mentioned this in rECOMe53d078e4e84: WikiPageWriter: Do not use the clone keyword.Jul 3 2024, 9:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 3 2024, 10:00 AM
gerritbot added a comment.Jul 4 2024, 5:24 PM

Change #1052143 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Validate mentor list using a JSON schema

https://gerrit.wikimedia.org/r/1052143

gerritbot added a comment.Jul 4 2024, 6:42 PM

Change #1052156 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] IConfigurationStore: Add support for writes without permissions

https://gerrit.wikimedia.org/r/1052156

gerritbot added a comment.Jul 5 2024, 9:31 AM

Change #1052156 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] IConfigurationStore: Add support for writes without permissions

https://gerrit.wikimedia.org/r/1052156

Urbanecm mentioned this in rECOM7bce681ffdb7: IConfigurationStore: Add support for writes without permissions.Jul 5 2024, 9:31 AM
Urbanecm_WMF mentioned this in T369608: Create a reasonable solution for working with CommunityConfiguration data.Jul 9 2024, 9:41 AM
gerritbot added a comment.Jul 9 2024, 10:19 AM

Change #1052939 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] Make it possible to skip permission checks from the provider level

https://gerrit.wikimedia.org/r/1052939

Urbanecm_WMF edited projects, added Growth-Team (FY2024-25 Q1 Sprint 1); removed Growth-Team (Sprint 17 (Growth Team)).Jul 9 2024, 4:17 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (FY2024-25 Q1 Sprint 1) board.
Etonkovidova closed subtask T368741: CommunityConfiguration's WikiPageStore does not support non-object input as Resolved.Jul 11 2024, 12:09 AM
gerritbot added a comment.Jul 15 2024, 1:27 PM

Change #1050621 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor list: Prepare for CommunityConfiguration extension

https://gerrit.wikimedia.org/r/1050621

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.14; 2024-07-16); removed MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 15 2024, 2:00 PM
gerritbot added a comment.Jul 16 2024, 1:46 PM

Change #1052939 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Make it possible to skip permission checks from the provider level

https://gerrit.wikimedia.org/r/1052939

Urbanecm mentioned this in rECOM078b1f246385: Make it possible to skip permission checks from the provider level.Jul 16 2024, 1:47 PM
gerritbot added a comment.Jul 16 2024, 1:58 PM

Change #1050627 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor list: Support CommunityConfiguration extension

https://gerrit.wikimedia.org/r/1050627

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.15; 2024-07-23); removed MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 16 2024, 2:00 PM
gerritbot added a comment.Jul 16 2024, 2:05 PM

Change #1051460 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor list: Respect mentor list change tag with CommunityConfiguration

https://gerrit.wikimedia.org/r/1051460

Etonkovidova closed subtask T368739: CommunityConfiguration: Allow client extensions to provide their own tag names as Resolved.Jul 20 2024, 1:36 AM
Michael changed the task status from Open to Stalled.Jul 24 2024, 10:26 AM
Michael edited projects, added Growth-Team (FY2024-25 Q1 Sprint 2); removed Growth-Team (FY2024-25 Q1 Sprint 1).
Michael moved this task from Incoming to Blocked / Needs Work on the Growth-Team (FY2024-25 Q1 Sprint 2) board.
Michael subscribed.

Let's move this to Blocked for now. It seems to require some resolution to T369608: Create a reasonable solution for working with CommunityConfiguration data.

Urbanecm_WMF removed Urbanecm_WMF as the assignee of this task.Aug 6 2024, 5:21 PM
Urbanecm_WMF removed a project: Growth-Team (FY2024-25 Q1 Sprint 2).

Unclaiming, as I'll be off for most of August.

Urbanecm_WMF mentioned this in T384244: CVE-2025-32079:Saving the right content to MediaWiki:GrowthMentors.json can take down the site.Jan 20 2025, 5:06 PM
Urbanecm_WMF renamed this task from Structured Mentor list should make use of CommunityConfiguration extension to Structured Mentor list should load its data using the CommunityConfiguration extension.Feb 12 2025, 7:37 PM
Urbanecm_WMF mentioned this in T386257: Replace CommunityStructuredMentorListValidator with a JSON schema validator.
Urbanecm_WMF closed this task as Resolved.Feb 12 2025, 7:39 PM
Urbanecm_WMF claimed this task.

The main purpose of this task was to load the data via Community Configuration, so that the WikiPageConfig{Reader,Writer} classes can be removed. This has been fulfilled. The remaining portion is migrating the validator. To make things more clear, I split the validator issue into T386257: Replace CommunityStructuredMentorListValidator with a JSON schema validator. Resolving this one.

Urbanecm_WMF mentioned this in T417422: Switch `GrowthMentorList` Community Configuration provider to JSON schema validation.Feb 13 2026, 3:52 PM
gerritbot added a comment.Feb 16 2026, 11:29 AM

Change #1052143 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] Validate mentor list using a JSON schema

Reason:

will replace with a different solution

https://gerrit.wikimedia.org/r/1052143

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2026, 11:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits