Page MenuHomePhabricator

Use latest Codex dialog slots on "add a link" dialog
Closed, ResolvedPublic

Description

We need to refactor the first implementation of the "add a link" dialog to use the latest Codex dialog slots that allow dialog customization.

Event Timeline

Change 904449 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):

[mediawiki/extensions/GrowthExperiments@master] documentation/frontend: refactor addlinkdialog to use Codex v0.8.0 dialog slots

https://gerrit.wikimedia.org/r/904449

Sgs changed the task status from Open to In Progress.Apr 6 2023, 6:25 PM
Sgs moved this task from Inbox to Sprint 0 (Growth Team) on the Growth-Team board.
Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 904449 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: refactor addlinkdialog to use Codex v0.8.0 dialog slots

https://gerrit.wikimedia.org/r/904449

Sgs changed the task status from In Progress to Open.Apr 12 2023, 10:10 AM
Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

The usage of the new Codex dialog slots can be seen in the Add a link dialog demo for the GrowthExperiments specific use case, and in the general purpose on-boarding dialog demo (T332767).

Anyways, it's not worth investing much QA time on this task and save it for the whole refactor in T329037. We will probably want to invest in QA and some design review once we resolve T332767 and T329037.