Page MenuHomePhabricator

Split transition and swipe logic into a MultiPane component
Closed, ResolvedPublic

Description

Since the design for onboarding steps includes a CSS transition between each of them and also swipe gesture support for mobile devices it would be nice to have this logic separated and reusable from the onboarding component.

Acceptance criteria

A new <MultiPane> component is created with the following requirements

  • Receives the steps via slots as in the current OnboardingDialog, step1, step2... stepN
  • Receives a currentStep prop (probably better bound via v-model:current-step, since the control buttons will remain in the OnboardingDialog)
  • Reacts to swipe gestures moving back/foward and produces an event when the currentStep is changed, eg: update:current-step
  • A transition is used between step navigation
  • Does not use any translated text (all text used is slotted)

The <OnboardingDialog> component will still be responsible for the checkbox result, dialog closing, onboarding result, etc.

Event Timeline

Sgs changed the task status from Open to In Progress.May 16 2023, 11:17 AM
Sgs renamed this task from Abstract transition and swipe logic into a MultiPane component to Split transition and swipe logic into a MultiPane component.May 16 2023, 11:20 AM

Change 921102 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Add a MultiPane component with transition and swipe logic

https://gerrit.wikimedia.org/r/921102

Change 922116 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Improve MultiPane component documentation

https://gerrit.wikimedia.org/r/922116

Change 921102 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Add a MultiPane component with transition and swipe logic

https://gerrit.wikimedia.org/r/921102

Change 922116 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Improve MultiPane component documentation

https://gerrit.wikimedia.org/r/922116

Change 925710 had a related patch set uploaded (by Viviana Yanez; author: L10n-bot):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: increase multipane component test coverage

https://gerrit.wikimedia.org/r/925710

Change 925710 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: increase multipane component test coverage

https://gerrit.wikimedia.org/r/925710