Adjust eslint configuration to disallow .done() and .fail()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Novem_Linguae
	Dec 6 2022, 9:47 AM

Description

Configure PageTriage continuous integration to disallow .done( and .fail(

To prevent bugs such as the infamous AFD bug (T238025), and to comply with https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Asynchronous_code

We already factored all of these out of the codebase in T319448

File that needs to be modified is likely .eslintrc.json

https://stackoverflow.com/a/65205076/3480193 looks like one way to do it

Details

	Subject	Repo	Branch	Lines +/-
	Add eslintrc rule to block .done/.fail usages	mediawiki/extensions/PageTriage	master	+12 -1

Customize query in gerrit

Related Objects

Mentioned Here: T238025: Page Curation fails to create AFD page
T319448: Refactor .done() and .fail() to .then()

Event Timeline

Novem_Linguae created this task.Dec 6 2022, 9:47 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 6 2022, 9:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kostajh moved this task from Inbox to Triaged on the Growth-Team board.Dec 7 2022, 12:23 PM

Change 867143 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] Add eslintrc rule to block .done/.fail usages

https://gerrit.wikimedia.org/r/867143

gerritbot added a project: Patch-For-Review.Dec 12 2022, 11:57 AM

kostajh renamed this task from Configure CI to disallow .done() and .fail() to Adjust eslint configuration to disallow .done() and .fail().Dec 12 2022, 11:57 AM

kostajh claimed this task.

kostajh moved this task from Backlog to Code Review on the PageTriage board.

Novem_Linguae closed this task as Resolved.Dec 12 2022, 1:27 PM

Novem_Linguae moved this task from Code Review to Done on the PageTriage board.

Change 867143 merged by jenkins-bot: