Page MenuHomePhabricator

DiscussionTools topic containers have inconsistent font sizes when browser default font size is changed
Open, Needs TriagePublic

Assigned To
Authored By
matmarex
Dec 13 2022, 9:46 PM
Referenced Files
F35862066: image.png
Dec 13 2022, 9:46 PM
F35862061: image.png
Dec 13 2022, 9:46 PM
F35862064: image.png
Dec 13 2022, 9:46 PM
F35862059: image.png
Dec 13 2022, 9:46 PM
F35862057: image.png
Dec 13 2022, 9:46 PM
F35861941: screen shot for en.VPT 2022-12-13
Dec 13 2022, 9:46 PM

Description

DiscussionTools topic containers have inconsistent font sizes when browser default font size is changed. The normal page text, headings, and section edit links respect the browser default font size (they don't use the exact value, but they scale relative to it, mostly by using CSS em units). The topic metadata and the subscribe buttons do not respect it, instead always using 14px font size.

We haven't noticed this before, because with default browser settings, Vector page text also uses a 14px font. (And we did it this way because the button is technically inside the heading, and using a relative size would require tediously adjusting it for every skin's different heading sizes. This should be easier to fix after T314714: Metadata and buttons should be inserted after a heading, not inside of it.)

Screenshot provided by @Jonesey95 (reported at https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project#c-Jonesey95-20221213185200-Matma_Rex-20221213155800) – looks like 14px or 15px font size:

screen shot for en.VPT 2022-12-13 (251×1 px, 93 KB)


To reproduce, go to your browser settings, search for "font size", and change the value. The default is "medium" or "16px".

  • Firefox:
    image.png (2×3 px, 113 KB)
  • Chrome etc.:
    image.png (2×3 px, 134 KB)

Additional screenshots:
(taken at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)?dtenable=1#Quarry_of_my_page_moves_that_renames_a_page_with_a_certain_suffix, but any page will behave the same)

Font sizeScreenshot
12px
image.png (2×3 px, 627 KB)
16px
image.png (2×3 px, 678 KB)
20px
image.png (2×3 px, 649 KB)

Event Timeline

My default font, and the one shown in my screen shot, is 14px Lucida Grande, FWIW. I also have a minimum font size of 11px set, if it matters. My browser is Firefox 107 for Mac OS. Thanks for digging into the root cause of this issue.

ppelberg added a project: Editing-team.
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

Change 883123 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove some `px` font-size overrides on topic metadata and buttons

https://gerrit.wikimedia.org/r/883123