As part of improvements to over time data updates, security-api will be expected to expire stale data. To do so, at minimum, the actor_data table will need an expiry column. Please update schema.sql to reflect this. As part of due diligence, please look over the other tables to see if they also need an expiry data. Afaik, they shouldn't since they refer to properties derived from the actor traits and can exist independently of the actor but please confirm.
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T325642: Implement data expiry
Event Timeline
Comment Actions
Change 917812 had a related patch set uploaded (by STran; author: STran):
[wikimedia/security/security-api@master] Add data expiry
Comment Actions
Change 917812 merged by jenkins-bot:
[wikimedia/security/security-api@master] Add data expiry
Comment Actions
As part of due diligence, please look over the other tables to see if they also need an expiry data. Afaik, they shouldn't since they refer to properties derived from the actor traits and can exist independently of the actor but please confirm.
@STran Has this part been done?
Comment Actions
Change 917945 had a related patch set uploaded (by STran; author: STran):
[wikimedia/security/security-api@master] Prefer insert time over an expiry time
Comment Actions
Yes. I confirmed we probably don't want to add this update to any of the subtype databases (eg. behaviors, proxies) since those will be shared across actors and any actor_data_* tables can be modified using the actor primary key instead of an expiry.
Comment Actions
Change 917945 merged by jenkins-bot:
[wikimedia/security/security-api@master] Prefer insert time over an expiry time