Route: GET /entities/items/{item_id}/labels
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
REST: Mark GET labels as production ready | mediawiki/extensions/Wikibase | master | +6 -7 |
Event Timeline
Comment Actions
🏷️ Task breakdown notes:
- add the GET /entities/items/{item_id}/labels route to our OpenAPI definition (@Silvan_WMDE creates task)
- implement ItemLabelsRetriever using a TermLookup (TermLookupLabelsRetriever) (@Muhammad_Yasser_Jazirahly_WMDE creates task)
- create a ItemLabelsRetriever interface with a getLabels( ItemId $itemId ): ?TermList; method
- use case (GetItemLabels) happy path (@Jakob_WMDE creates task)
- create and return success response using the data from the ItemLabelsRetriever, and revision metadata
- create a LabelsSerializer (we don't need a dedicated presenter) (@Silvan_WMDE creates task)
- extract from ItemDataSerializer
- use in ItemDataSerializer once done
- route handler (happy path only) (@Ollie.Shotton_WMDE creates task)
- same middlewares as GetItemRouteHandler
- calls json_encode on the serializer result
- e2e tests
- validate request and error if item id is invalid (just uses the existing ItemIdValidator but still create a dedicated use case validator) (@Muhammad_Yasser_Jazirahly_WMDE creates task)
- use case + route handler
- e2e tests
- return appropriate response if the item is a redirect or does not exist (@Jakob_WMDE creates task)
- use case + route handler
- e2e tests
- spec tests (@Silvan_WMDE creates task)
- create a read model for labels (get rid of any TermList usage) (@Ollie.Shotton_WMDE creates task)
Comment Actions
Change 889947 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Mark GET labels as production ready
Comment Actions
Change 889947 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Mark GET labels as production ready