"(other edits)" leading space before it is not styled correctly
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jonesey95
	Jan 6 2023, 12:42 AM

Description

Steps to replicate the issue (include links if applicable):

Go to your Watchlist and find a diff showing "other edits" like a Twinkle or Undo edit.

What happens?:
hiding text tagged with .mw-tag-other-edits fails to hide the leading space before "(other edits)", so when you hide it, you are left with tags that look like "(Tag: Twinkle )" or "(Tags: Twinkle , Undo )".

What should have happened instead?:
The leading space before "(other edits)" should be styled with .mw-tag-other-edits so that it can be hidden properly.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	ChangeTags: Move space inside .mw-tag-other-edits	mediawiki/core	master	+8 -8

Customize query in gerrit

Related Objects

Mentioned Here: T301063: The "tag name" on the change line should link directly to "tagged changes"

Event Timeline

Jonesey95 created this task.Jan 6 2023, 12:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2023, 12:42 AM

YFdyh000 subscribed.Jan 6 2023, 12:45 AM

Nardog subscribed.Jan 6 2023, 12:46 AM

The font size issue is Local-Wiki-Template-And-Gadget-Issues and is resolved now (though perhaps not perfectly).

I think the other part here is a reasonable ask.

Legoktm renamed this task from "(other edits)" text size violates accessibility policy, and the leading space before it is not styled correctly to "(other edits)" leading space before it is not styled correctly.Jan 6 2023, 7:03 AM

Legoktm updated the task description. (Show Details)

AntiCompositeNumber claimed this task.Jan 7 2023, 2:10 AM

Change 876270 had a related patch set uploaded (by AntiCompositeNumber; author: AntiCompositeNumber):

[mediawiki/core@master] ChangeTags: Move space inside .mw-tag-other-edits

https://gerrit.wikimedia.org/r/876270

gerritbot added a project: Patch-For-Review.Jan 7 2023, 2:35 AM

Change 876270 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Move space inside .mw-tag-other-edits

https://gerrit.wikimedia.org/r/876270

Legoktm closed this task as Resolved.Jan 7 2023, 4:07 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2023, 4:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 7 2023, 5:00 AM