Page MenuHomePhabricator
Create Task
Maniphest T326454

Creation of dynamic property Mail_smtp::$greeting is deprecated
Closed, ResolvedPublic
Actions

Description

When running under PHP 8.2, if an SMTP server is specified in LocalSettings.php using $wgSMTP, this deprecation warning is generated when sending an email (and is no longer silenced by MediaWiki since 9a2fac1e47c0d076). The PEAR Mail fix has already been merged upstream and is planned for an upcoming 1.5.1 release.

Upstream pull request: https://github.com/pear/Mail/pull/22
Upstream commit: https://github.com/pear/Mail/commit/11b5eeea6c60d10dca21053b60df19a8503b1402

Details

SubjectRepoBranchLines +/-
Add release note for "Update pear/mail to 1.5.1"mediawiki/coremaster+1 -0
Update pear/mail to 1.5.1mediawiki/coreREL1_40+1 -1
Update pear/mail to 1.5.1mediawiki/coreREL1_39+1 -1
Update pear/mail to 1.5.1mediawiki/vendorREL1_39+67 -34
Update pear/mail to 1.5.1mediawiki/vendorREL1_40+67 -34
Update pear/mail to 1.5.1mediawiki/coremaster+1 -1
Update pear/mail to 1.5.1mediawiki/vendorREL1_39+67 -34
Update pear/mail to 1.5.1mediawiki/vendorREL1_40+67 -34
Update pear/mail to 1.5.1mediawiki/vendormaster+67 -34
Customize query in gerrit

Related Objects
Search...

Event Timeline

PleaseStand created this task.Jan 7 2023, 3:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2023, 3:22 AM
PleaseStand updated the task description. (Show Details)Jan 7 2023, 3:27 AM
Reedy moved this task from Backlog to Patch merged upstream on the Upstream board.Jan 7 2023, 1:17 PM
Reedy moved this task from Backlog to Other on the PHP 8.2 support board.Jan 8 2023, 11:39 PM
PleaseStand updated the task description. (Show Details)Jan 11 2023, 3:12 AM
• DooDee renamed this task from Creation of dynamic property Mail_smtp::$greeting is deprecated to Creation of dynamic property Mail_smtp::$Thailand.th is deprecated.Apr 5 2023, 10:12 AM
• DooDee removed projects: Upstream, PHP 8.2 support.
• DooDee updated the task description. (Show Details)
Mainframe98 renamed this task from Creation of dynamic property Mail_smtp::$Thailand.th is deprecated to Creation of dynamic property Mail_smtp::$greeting is deprecated.Apr 5 2023, 10:14 AM
Mainframe98 added projects: Upstream, PHP 8.2 support.
Mainframe98 updated the task description. (Show Details)
Reedy changed the task status from Open to Stalled.Jul 7 2023, 5:01 PM
PleaseStand changed the task status from Stalled to Open.Aug 11 2023, 12:39 AM

PEAR Mail 1.5.1 was released a couple days ago, so we can now apply this eight month old bug fix to MediaWiki.

gerritbot added a comment.Aug 11 2023, 2:00 AM

Change 947977 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/vendor@master] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947977

gerritbot added a project: Patch-For-Review.Aug 11 2023, 2:00 AM

Change 947978 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/core@master] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947978

gerritbot added a comment.Aug 11 2023, 2:10 AM

Change 947979 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/vendor@REL1_40] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947979

gerritbot added a comment.Aug 11 2023, 2:11 AM

Change 947980 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/vendor@REL1_39] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947980

gerritbot added a comment.Aug 11 2023, 2:29 AM

Change 947977 merged by jenkins-bot:

[mediawiki/vendor@master] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947977

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 11 2023, 3:00 AM
gerritbot added a comment.Aug 11 2023, 3:08 AM

Change 947979 abandoned by PleaseStand:

[mediawiki/vendor@REL1_40] Update pear/mail to 1.5.1

Reason:

until change merged on master

https://gerrit.wikimedia.org/r/947979

gerritbot added a comment.Aug 11 2023, 3:09 AM

Change 947980 abandoned by PleaseStand:

[mediawiki/vendor@REL1_39] Update pear/mail to 1.5.1

Reason:

until change merged on master

https://gerrit.wikimedia.org/r/947980

gerritbot added a comment.Aug 11 2023, 3:37 AM

Change 947978 merged by jenkins-bot:

[mediawiki/core@master] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947978

gerritbot added a comment.Aug 11 2023, 4:42 AM

Change 947987 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/vendor@REL1_40] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947987

gerritbot added a comment.Aug 11 2023, 4:43 AM

Change 947988 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/vendor@REL1_39] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947988

PleaseStand mentioned this in T210685: Depends-On should not work across branches.Aug 11 2023, 6:36 AM
gerritbot added a comment.Aug 11 2023, 6:38 AM

Change 947915 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/core@REL1_40] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947915

gerritbot added a comment.Aug 11 2023, 6:44 AM

Change 947916 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/core@REL1_39] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947916

gerritbot added a comment.Aug 11 2023, 7:58 AM

Change 948085 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/core@master] Add release note for "Update pear/mail to 1.5.1"

https://gerrit.wikimedia.org/r/948085

gerritbot added a comment.Aug 16 2023, 7:26 AM

Change 947987 merged by Jforrester:

[mediawiki/vendor@REL1_40] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947987

gerritbot added a comment.Aug 16 2023, 7:26 AM

Change 947988 merged by Jforrester:

[mediawiki/vendor@REL1_39] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947988

gerritbot added a comment.Aug 16 2023, 7:36 AM

Change 947916 merged by jenkins-bot:

[mediawiki/core@REL1_39] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947916

gerritbot added a comment.Aug 16 2023, 7:37 AM

Change 947915 merged by jenkins-bot:

[mediawiki/core@REL1_40] Update pear/mail to 1.5.1

https://gerrit.wikimedia.org/r/947915

ReleaseTaggerBot added projects: MW-1.40-notes, MW-1.39-notes.Aug 29 2023, 6:10 PM
Reedy closed this task as Resolved.Oct 7 2023, 6:28 PM
Reedy assigned this task to PleaseStand.
Reedy triaged this task as Low priority.
Reedy added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated.
gerritbot added a comment.Oct 7 2023, 6:44 PM

Change 948085 merged by jenkins-bot:

[mediawiki/core@master] Add release note for "Update pear/mail to 1.5.1"

https://gerrit.wikimedia.org/r/948085

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.30; 2023-10-10); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Oct 7 2023, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL