Page MenuHomePhabricator
Create Task
Maniphest T326677

Update DiscussionTools TOC additions for Vector 2022 after parser changes
Closed, ResolvedPublic
Actions

Description

Internal parser changes related to T296025 remove the mechanism we used to customize how Vector 2022 table of contents displays sections modified by DiscussionTools.

We'll need a new mechanism and to update the code to use it.

Details

SubjectRepoBranchLines +/-
Update generating DiscussionTools TOC additions after parser changesmediawiki/extensions/DiscussionToolsmaster+8 -8
Add test for DiscussionTools TOC additionsmediawiki/extensions/DiscussionToolsmaster+34 -0
Update displaying DiscussionTools TOC additions after parser changesmediawiki/skins/Vectormaster+2 -2
Bump parsoid to 0.17.0-a11mediawiki/vendormaster+444 -148
SectionMetadata: Add ::setExtensionData() to let extensions set custom datamediawiki/services/parsoidmaster+102 -3
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jan 10 2023, 9:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2023, 9:08 PM
matmarex claimed this task.Jan 10 2023, 9:08 PM
matmarex added a project: Editing-team (Kanban Board).
gerritbot added a comment.Jan 10 2023, 9:28 PM

Change 878196 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Update generating DiscussionTools TOC additions after parser changes

https://gerrit.wikimedia.org/r/878196

gerritbot added a project: Patch-For-Review.Jan 10 2023, 9:28 PM

Change 878197 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Update displaying DiscussionTools TOC additions after parser changes

https://gerrit.wikimedia.org/r/878197

gerritbot added a comment.Jan 10 2023, 9:29 PM

Change 878188 had a related patch set uploaded (by Bartosz Dziewoński; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] SectionMetadata: Add extData property to let extensions set custom data

https://gerrit.wikimedia.org/r/878188

PatchDemoBot added a comment.Jan 10 2023, 9:32 PM

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/1ca3d80c4b/wiki/Talk:DiscussionTools

gerritbot added a comment.Jan 10 2023, 10:18 PM

Change 878206 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Add test for DiscussionTools TOC additions

https://gerrit.wikimedia.org/r/878206

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jan 10 2023, 10:20 PM
gerritbot added a comment.Jan 13 2023, 9:56 PM

Change 878188 merged by jenkins-bot:

[mediawiki/services/parsoid@master] SectionMetadata: Add ::setExtensionData() to let extensions set custom data

https://gerrit.wikimedia.org/r/878188

gerritbot added a comment.Jan 16 2023, 5:10 PM

Change 880501 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a11

https://gerrit.wikimedia.org/r/880501

gerritbot added a comment.Jan 16 2023, 5:48 PM

Change 880501 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a11

https://gerrit.wikimedia.org/r/880501

PatchDemoBot added a comment.Jan 16 2023, 8:08 PM

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1ca3d80c4b/w/

PatchDemoBot added a comment.Jan 16 2023, 8:10 PM

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/637dfdccca/wiki/Talk:DiscussionTools?useskin=vector-2022

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jan 17 2023, 7:41 PM
gerritbot added a comment.Jan 19 2023, 9:37 PM

Change 878196 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update generating DiscussionTools TOC additions after parser changes

https://gerrit.wikimedia.org/r/878196

gerritbot added a comment.Jan 19 2023, 9:37 PM

Change 878197 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update displaying DiscussionTools TOC additions after parser changes

https://gerrit.wikimedia.org/r/878197

gerritbot added a comment.Jan 19 2023, 10:05 PM

Change 878206 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add test for DiscussionTools TOC additions

https://gerrit.wikimedia.org/r/878206

matmarex edited projects, added Editing QA; removed Patch-For-Review.EditedJan 20 2023, 2:18 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

QA instructions: Ensure the TOC works as before :)

There are some known issues not related to this work:

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 20 2023, 9:01 AM
EAkinloose edited projects, added Verified; removed Editing QA.Feb 9 2023, 6:16 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Feb 13 2023, 4:44 PM
PatchDemoBot added a comment.Feb 21 2023, 11:12 PM

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/637dfdccca/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL