Change 879173 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/php/wikidiff2@master] [WIP] Include spaces as the word suffix

https://gerrit.wikimedia.org/r/879173

Change 879174 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/php/wikidiff2@master] Remove word suffix concept

https://gerrit.wikimedia.org/r/879174

There was a comment indicating that suffix was only supposed to contain a single space, not all spaces following the word. That would make more sense and would correctly highlight the added space in the screenshot above. However, insertion of a single space between letters and punctuation would not be highlighted correctly. And with the current formatting code, changing only letters would lead to the following space being highlighted even when it is unchanged.

Removing the suffix concept is probably the best option at this point.

Either way, it's not ideal. With the current wikidiff2, if you match a paragraph of text with another paragraph that uses none of the same words, the LCS is just the spaces. You can even match a text with a string that contains only spaces, and each space will be in the LCS. It's a reminder that displaying diffs for humans is not just a matter of finding the shortest edit script.

Maybe a better idea would be to do a diff with the spaces joined to words, and then do a space-splitting pass which will make local adjustments to the edit boundaries.

Change 879173 abandoned by Tim Starling:

[mediawiki/php/wikidiff2@master] [WIP] Include spaces as the word suffix

Reason:

https://gerrit.wikimedia.org/r/879173

In T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff), I posted an example of how bad this can get in MobileDiff:

In addition to joining together words and spaces, another thing that could help improve the output in situations like this would be joining together substitutions that have too small of a separator between them, as measured by word count, word frequency, and/or character count. This would probably negate any time improvements though.

27% is honestly quite a lot. Is there a way I can push this forward? For example, putting it in tech news and see what people think.

In T326773#12196367, @Ladsgroup wrote:

27% is honestly quite a lot. Is there a way I can push this forward? For example, putting it in tech news and see what people think.

We don't have a patch for what I think is the best simple change: just include a single space following a word as the suffix. My abandoned patch includes all spaces following the word in the suffix. So we would need that patch and some sample screenshots. Maybe a demo site on toolforge. There's tools/demo/demo.php in the source tree -- for my 2023 project I put it on the web somewhere.

Sounds good. I play with it a bit in my volunteer time.

Change #1328352 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/php/wikidiff2@master] Simplify concept of suffix

https://gerrit.wikimedia.org/r/1328352

Change #1328354 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/php/wikidiff2@master] Compleltely remove suffix in Word

https://gerrit.wikimedia.org/r/1328354

I have two alternative proposals. The first one is tamer, the second one is more radical. Let me know which one do you prefer and I'll set up a system for it.

Change #1349540 had a related patch set uploaded (by Ladsgroup-claude; author: Ladsgroup-claude):

[mediawiki/php/wikidiff2@master] [WIP] Simplify concept of suffix

https://gerrit.wikimedia.org/r/1349540