Page MenuHomePhabricator
Create Task
Maniphest T327065

Remove CommentFormatter from EventFactory constructor, or otherwise make its usage optional
Closed, ResolvedPublic
Actions

Description

Parsed comment support was added in T170145: Add parsedcomment to recentchange stream. As noted in a patch discussion in EventBus, it would be nice to have the CommentFormatter as an optional service, because using it triggers code that is not safe to call in no-session contexts.

Details

SubjectRepoBranchLines +/-
EventFactory: Remove CommentFormatter from service injectionmediawiki/extensions/EventBusmaster+34 -11
development/mediawiki/page/chage - 2.0.0 - remove comment_htmlschemas/event/primarymaster+1 K -47
EventFactory: Make CommentFormatter an optional dependencymediawiki/extensions/EventBusmaster+26 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Jan 16 2023, 12:20 PM
Restricted Application added a project: Data-Engineering. · View Herald TranscriptJan 16 2023, 12:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh claimed this task.Jan 16 2023, 12:29 PM
kostajh added a project: Growth-Team (Sprint 0 (Growth Team)).
kostajh added a parent task: T306034: Write GrowthExperiments image recommendation user feedback to EventGate.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jan 16 2023, 12:38 PM

Change 880457 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/EventBus@master] EventFactory: Make CommentFormatter an optional dependency

https://gerrit.wikimedia.org/r/880457

gerritbot added a project: Patch-For-Review.Jan 16 2023, 12:38 PM
kostajh changed the task status from Open to In Progress.Jan 16 2023, 1:00 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Ottomata subscribed.Jan 17 2023, 3:44 PM
gerritbot added a comment.Jan 18 2023, 6:52 AM

Change 880457 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] EventFactory: Make CommentFormatter an optional dependency

https://gerrit.wikimedia.org/r/880457

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 18 2023, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 18 2023, 7:30 AM
JArguello-WMF moved this task from Backlog to Radar on the Event-Platform board.Jan 25 2023, 3:26 PM
gerritbot added a comment.Jan 26 2023, 9:03 PM

Change 884088 had a related patch set uploaded (by Ottomata; author: Ottomata):

[schemas/event/primary@master] development/mediawiki/page/chage - 2.0.0 - remove comment_html

https://gerrit.wikimedia.org/r/884088

gerritbot added a project: Patch-For-Review.Jan 26 2023, 9:03 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 28 2023, 1:23 AM
Tgr subscribed.

I don't think we are expected to review the other patch, nor are we affected by it, so moving this to QA.

gerritbot added a comment.Jan 30 2023, 7:06 PM

Change 884088 merged by Ottomata:

[schemas/event/primary@master] development/mediawiki/page/chage - 2.0.0 - remove comment_html

https://gerrit.wikimedia.org/r/884088

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2023, 7:30 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.21; 2023-01-30); removed MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 30 2023, 8:00 PM
• EChetty edited projects, added Data-Engineering-Planning; removed Data-Engineering.Jan 31 2023, 4:10 PM
• EChetty moved this task from Backlog to Event Platform on the Data-Engineering-Planning board.Jan 31 2023, 4:12 PM
gerritbot added a comment.Feb 9 2023, 1:29 PM

Change 888000 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/EventBus@master] EventFactory: Remove CommentFormatter from service injection

https://gerrit.wikimedia.org/r/888000

gerritbot added a project: Patch-For-Review.Feb 9 2023, 1:29 PM
gerritbot added a comment.Feb 13 2023, 8:13 AM

Change 888000 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] EventFactory: Remove CommentFormatter from service injection

https://gerrit.wikimedia.org/r/888000

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 8:31 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 13 2023, 9:00 AM
kostajh closed this task as Resolved.Feb 16 2023, 11:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits