Page MenuHomePhabricator
Create Task
Maniphest T327385

SX: Deletion of draft translations doesn't work
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. Go to Section Translation in a production wiki of your preference
  2. Create at least one draft translation
  3. Go to SX dashboard again
  4. Go to "In progress" tab
  5. Try to delete a draft translation by clicking on the "Trash can" icon

What happens?:
The draft translation is not deleted but instead the translation is restored, so that the user can continue translating that section.

What should have happened instead?:
The draft translation should have been deleted.

Other information (browser name/version, screenshots, etc.):
Screencast from test wiki:

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20230321mediawiki/extensions/ContentTranslationmaster+684 -672
SX: Support multiple translation work deletion at oncemediawiki/extensions/ContentTranslationmaster+2 -4
CX3 Build 0.2.0+20230206mediawiki/extensions/ContentTranslationmaster+210 -137
SX: Support deletion of draft section translationsmediawiki/extensions/ContentTranslationmaster+257 -2
Customize query in gerrit

Event Timeline

ngkountas created this task.Jan 19 2023, 10:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2023, 10:13 AM
ngkountas claimed this task.Jan 19 2023, 10:13 AM
ngkountas triaged this task as Medium priority.
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2023-January-March) board.Jan 23 2023, 3:40 PM
gerritbot added a comment.Jan 23 2023, 3:42 PM

Change 882672 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Support deletion of draft section translations

https://gerrit.wikimedia.org/r/882672

gerritbot added a project: Patch-For-Review.Jan 23 2023, 3:42 PM
gerritbot added a comment.Jan 24 2023, 11:30 AM

Change 882672 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Support deletion of draft section translations

https://gerrit.wikimedia.org/r/882672

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2023, 11:31 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 24 2023, 12:00 PM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2023-January-March) board.Jan 27 2023, 2:11 PM
gerritbot added a comment.Feb 6 2023, 9:25 AM

Change 886831 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230206

https://gerrit.wikimedia.org/r/886831

gerritbot added a project: Patch-For-Review.Feb 6 2023, 9:25 AM
gerritbot added a comment.Feb 6 2023, 11:00 AM

Change 886831 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230206

https://gerrit.wikimedia.org/r/886831

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2023, 11:32 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 6 2023, 12:00 PM
Nikerabbit moved this task from Check after deployment to Needs QA on the Language-Team (Language-2023-January-March) board.Feb 22 2023, 9:14 AM
EChukwukere-WMF subscribed.Feb 28 2023, 4:48 AM

Test status: QA Failed

When deleting an inprogress translation, it does not delete but delete other inprogress translations.

Could this be because I have this inprogress before this current fix? This should not be happening

EChukwukere-WMF moved this task from Needs QA to In Progress on the Language-Team (Language-2023-January-March) board.Feb 28 2023, 4:48 AM
gerritbot added a comment.Mar 10 2023, 3:40 PM

Change 896373 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Support multiple translation work deletion at once

https://gerrit.wikimedia.org/r/896373

gerritbot added a project: Patch-For-Review.Mar 10 2023, 3:40 PM
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2023-January-March) board.Mar 10 2023, 3:40 PM
gerritbot added a comment.Mar 13 2023, 4:52 AM

Change 896373 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Support multiple translation work deletion at once

https://gerrit.wikimedia.org/r/896373

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Mar 13 2023, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 13 2023, 5:10 AM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2023-January-March) board.Mar 13 2023, 8:05 AM
gerritbot added a comment.Mar 21 2023, 3:30 AM

Change 901328 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230321

https://gerrit.wikimedia.org/r/901328

gerritbot added a project: Patch-For-Review.Mar 21 2023, 3:30 AM
gerritbot added a comment.Mar 21 2023, 8:16 AM

Change 901328 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230321

https://gerrit.wikimedia.org/r/901328

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2023, 8:30 AM
Nikerabbit added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 28 2023, 7:32 AM
ngkountas moved this task from Check after deployment to Needs QA on the Language-Team (Language-2023-January-March) board.Mar 30 2023, 10:43 AM
Pginer-WMF edited projects, added Language-Team (Language-2023-April-June); removed Language-Team (Language-2023-January-March).Mar 31 2023, 1:23 PM
Pginer-WMF moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2023-April-June) board.
EChukwukere-WMF added a comment.Apr 12 2023, 4:06 AM

Test status: QA PASS

I am able to delete translations in progress

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2023-April-June) board.Apr 12 2023, 4:07 AM
Pginer-WMF closed this task as Resolved.Apr 26 2023, 10:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL