Page MenuHomePhabricator

mobile preferences toggles skip preference checkbox handlers
Closed, ResolvedPublicBUG REPORT


Steps to replicate the issue (include links if applicable):
Per our findings in T323050: SPIKE verify that mobile preferences toggles aren't overwriting existing checkbox handlers [8hr]

  • create an onclick handler for a preference checkbox
  • navigate to mobile preferences
  • change the toggle for that preference

What happens?:
the onclick handler will not run

What should have happened instead?:
handlers for preferences should run

Software version (skip for WMF-hosted wikis like Wikipedia):
We had to go out of our way to create this scenario, we're not aware of this problem existing in the wild.

Other information (browser name/version, screenshots, etc.):

Event Timeline

Samwalton9-WMF subscribed.

(We talked about whether this was an MVP blocker, and seconds after I added it as a parent task I remembered we concluded that it wasn't, since we're not aware of this being an in-production issue today)

jsn.sherman claimed this task.

Since, the checkbox change event is well handled. The only practical click-related issue we were seeing was related to handling label clicks, which are now covered as well.