Maniphest T327536

Hide "Add topic" footer on talk pages that have not yet been created
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Jan 20 2023, 6:23 PM

Tags

Referenced Files

	F36762193: Screenshot 2023-02-06 at 18.27.52.png
	Feb 6 2023, 5:28 PM

	F36360087: Screen Shot 2023-01-20 at 10.23.40 AM.png
	Jan 20 2023, 6:23 PM

	F36360084: IMG_6235.PNG
	Jan 20 2023, 6:23 PM

Subscribers

Description

Behavior

On a wiki where the suite of mobile discussion tools are available, visit a talk page that as not yet been created. E.g. https://fr.m.wikipedia.org/wiki/1_500_m%C3%A8tres_nage_libre_masculin_aux_Jeux_olympiques_d%27%C3%A9t%C3%A9_de_1924 .

❗️ Actual

Notice two buttons appear that do the same thing: Start a discussion and Add topic

IMG_6235.PNG (2×1 px, 343 KB)

✅ Expected

Notice one appears: Start a discussion

Screen Shot 2023-01-20 at 10.23.40 AM.png (1×718 px, 173 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Hide "Add topic" footer on talk pages when empty state is shown	mediawiki/extensions/DiscussionTools	master	+0 -3

Customize query in gerrit

Event Timeline

• ppelberg created this task.Jan 20 2023, 6:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2023, 6:23 PM

• ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jan 20 2023, 6:24 PM

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

matmarex claimed this task.Jan 23 2023, 7:04 PM

Change 882717 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Hide "Add topic" footer on talk pages when empty state is shown

https://gerrit.wikimedia.org/r/882717

gerritbot added a project: Patch-For-Review.Jan 23 2023, 8:16 PM

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jan 23 2023, 8:17 PM

Change 882717 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Hide "Add topic" footer on talk pages when empty state is shown

https://gerrit.wikimedia.org/r/882717

Maintenance_bot removed a project: Patch-For-Review.Jan 31 2023, 3:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Jan 31 2023, 4:00 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Feb 1 2023, 12:45 AM

matmarex added a project: Editing QA.

• ppelberg moved this task from Inbox to High Priority on the Editing QA board.Feb 6 2023, 5:00 PM

Tested on https://simple.m.wikipedia.beta.wmflabs.org/

Screenshot 2023-02-06 at 18.27.52.png (1×720 px, 127 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 6 2023, 5:28 PM

• ppelberg closed this task as Resolved.Feb 6 2023, 5:44 PM