Page MenuHomePhabricator
Create Task
Maniphest T328093

[betalabs] mobile -Opening Preview search produces TypeError: this.$el.querySelectorAll is not a function
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. On enwiki betalabs perform a search (add &quickViewEnableMobile=1 to the url), e.g. search term: galaxy
  2. Click on the arrow to open search preview - the Console will display the following error:
TypeError: this.$el.querySelectorAll is not a function. (In 'this.$el.querySelectorAll('a, button, input, textarea, select, details, [tabindex]:not([tabindex="-1"])')', 'this.$el.querySelectorAll' is undefined)

Details

SubjectRepoBranchLines +/-
mobile -Opening Preview search produces error this.$el.querySelectorAllmediawiki/extensions/SearchVuemaster+17 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 26 2023, 11:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2023, 11:27 PM
SimoneThisDot claimed this task.Jan 27 2023, 8:25 AM
SimoneThisDot moved this task from Triage to SDAW Search Improvements on the Structured-Data-Backlog board.
SimoneThisDot edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
SimoneThisDot moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Jan 27 2023, 8:28 AM

Change 884223 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] mobile -Opening Preview search produces error this.$el.querySelectorAll

https://gerrit.wikimedia.org/r/884223

gerritbot added a project: Patch-For-Review.Jan 27 2023, 8:28 AM
gerritbot added a comment.Jan 30 2023, 7:51 AM

Change 884223 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] mobile -Opening Preview search produces error this.$el.querySelectorAll

https://gerrit.wikimedia.org/r/884223

SimoneThisDot mentioned this in rESVU8c19a4e6f094: mobile -Opening Preview search produces error this.$el.querySelectorAll.Jan 30 2023, 7:52 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 30 2023, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 30 2023, 8:30 AM
SimoneThisDot moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 30 2023, 3:19 PM
Etonkovidova updated the task description. (Show Details)Jan 30 2023, 5:13 PM
Etonkovidova updated the task description. (Show Details)Jan 31 2023, 7:04 PM
Etonkovidova closed this task as Resolved.Jan 31 2023, 7:07 PM

Checked in enwiki betalabs - the error is not displayed; will be checked in production as part of overall monitoring/testing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL