Page MenuHomePhabricator

Missing space between multiple authors on German-language Diff blog
Open, Needs TriagePublicBUG REPORT

Description

This is probably a trivial bug, but I don't know where else to ask for a fix.

Steps to reproduce:

  • Open any Diff posts in German language with multiple authors. Examples: 1, 2 or 3.
  • Check the byline in the meta data of the post (below title).

What happens:

  • The two author names are connected through the word und without any spaces.
  • In other languages, the same posts have spaces between the author names and the connecting and.

What should happen instead:

  • There should be spaces before and after the and. If there are more than two authors, commas followed by a space should be used.

Event Timeline

I'll have to dig into this one. It's not apparent to me why this is only happening to German and not all languages. The conjunction is a translated string ("und", "y", "et", etc.) so it should be breaking consistency across languages!

A temporary fix is in place. I have a task on the list with our developers to have a more consistent fix, should be resolved in the next few months.

Where is the code, especially the temporary fix? Maybe volunteers could help if they had access to the code. Also, I’m not sure if the following are related:

  • the month name isn’t translated: it should be Januar instead of January;
  • “by” isn’t translated.

I had filed T328221 for the latter problem.

Thanks for the pointer!

Where is the code, especially the temporary fix? Maybe volunteers could help if they had access to the code.

The temporary fix is in the WordPress customized, accessible to Admins only.

Also, I’m not sure if the following are related:

Some strings are able to be translated. Login and visit this link: https://diff.wikimedia.org/wp-admin/admin.php?page=mlang_strings

We need to improve support for translatable interface on Diff (in our WordPress theme). It’s on the roadmap, but I do not have an estimate on when we’ll get to it.

Some strings are able to be translated. Login and visit this link: https://diff.wikimedia.org/wp-admin/admin.php?page=mlang_strings

Thanks, but I know this translation interface, and the things I listed are those that are not translatable there.