Page MenuHomePhabricator
Create Task
Maniphest T328281

[WDQS-GUI] Perform update of `bootstrap-table`
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

In the task T327029: WDQS GUI should not remember column sort orderings from previous queries or previous runs, we reverted the update of bootstrap-table from v1.21.1 to v1.12.2 as it was deemed as the cause of the bug described.

In order to ensure that this bug will not occur again due to an automatic update. We can either lock the version of bootstrap-table and await newer versions where this issue does not occur, or update our code to ensure this regression does not repeat. See the following comment by @Lucas_Werkmeister_WMDE for a possible hint on where to start T327029#8528123.

Acceptance Criteria:

EITHER

  • The library is updated and the regression in bootstrap-table does not affect our code

OR

  • The library version is locked, and a new task is scheduled to check in on a possible update which fixes our issue

Notes

  • In case the issue turns out to be a bug in bootstrap-table we should consider upstreaming a fix to that library.

Details

SubjectRepoBranchLines +/-
Merging from d20c6591ab7b311d75bff636e26dc01c6ae88945wikidata/query/gui-deployproduction+21 -20
Add empty commit to allow query/gui build to runwikidata/query/guimaster+0 -0
Customize query in gerrit

Related Objects

Event Timeline

ItamarWMDE created this task.Jan 30 2023, 10:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2023, 10:56 AM
LucasWerkmeister unsubscribed.Jan 30 2023, 11:05 AM
Aklapper added a project: Wikidata Query UI.Jan 30 2023, 12:52 PM
Maintenance_bot added a project: Wikidata.Jan 30 2023, 1:29 PM
ItamarWMDE added projects: wmde-wikidata-tech, Wikidata Dev Team.Jan 30 2023, 2:12 PM
Lucas_Werkmeister_WMDE subscribed.EditedFeb 9 2023, 2:47 PM
In T327029#8528123, @Lucas_Werkmeister_WMDE wrote:

Apparently we’re using the bootstrap-table cookie extension, but it’s only supposed to save the bs.table.pageList, whatever that means…

TableResultBrowser.js
cookie: true,
cookieIdTable: '1',
cookieExpire: '1y',
cookiesEnabled: [ 'bs.table.pageList' ],

We should check if this is a regression in bootstrap-table or if we’re doing something wrong, and what the pageList thing even is (maybe we can just get rid of the whole cookie extension). In the meantime, I think we can safely revert to the previous version of the library.

This cookie remembers your selection of the page size:

image.png (240×464 px, 13 KB)

I’d say we should keep this, or at least I remember noticing that this is automatically saved, and finding it useful, years ago. So I don’t think we should throw out the cookie extension altogether.

ItamarWMDE added a comment.Feb 14 2023, 2:11 PM

Prio Notes:

  • Could affect end users / production (when dependabot creates a new PR with a version where this bug still occurs, and we merge it while doing chores)
  • Does not affect development efforts
  • Does not affect onboarding efforts
  • Does not additional stakeholders
ItamarWMDE moved this task from Incoming to [DOT] Prioritized on the wmde-wikidata-tech board.Feb 14 2023, 2:11 PM
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.Feb 14 2023, 3:02 PM
ItamarWMDE renamed this task from Perform update of `bootstrap-table` to [SW] Perform update of `bootstrap-table`.Feb 15 2023, 8:57 AM
ItamarWMDE added a subscriber: LucasWerkmeister.
ItamarWMDE renamed this task from [SW] Perform update of `bootstrap-table` to Perform update of `bootstrap-table`.Feb 15 2023, 10:19 AM
Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.Feb 15 2023, 10:22 AM
Lydia_Pintscher moved this task from [DOT] Tech Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Feb 15 2023, 10:39 AM
Lucas_Werkmeister_WMDE added a comment.EditedMar 6 2023, 11:27 AM

Apparently there’s a v1.21.3 now (Dependabot change), we can check if that still has the regression or not.

Edit: And a v1.21.4 (Dependabot change)

ItamarWMDE renamed this task from Perform update of `bootstrap-table` to [WDQS-GUI] Perform update of `bootstrap-table`.Mar 14 2023, 1:35 PM
ItamarWMDE added a subscriber: LucasWerkmeister.
LucasWerkmeister unsubscribed.Mar 14 2023, 1:48 PM
karapayneWMDE set the point value for this task to 3.Aug 8 2023, 9:09 AM
karapayneWMDE moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
karapayneWMDE added a subscriber: LucasWerkmeister.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 8 2023, 9:30 AM
Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.
ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 9 2023, 7:18 PM
Lucas_Werkmeister_WMDE claimed this task.EditedAug 11 2023, 12:40 PM
Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.

Okay, I’ve tested bump bootstrap-table from 1.21.1 to 1.22.1 and was unable to reproduce T327029. (When checking out an older commit, with the bad bootstrap-table version, I was able to reproduce it.)

Lucas_Werkmeister_WMDE moved this task from Doing to Product Verification on the Wikidata Dev Team (Sprint-∞) board.EditedAug 11 2023, 12:48 PM

Update merged.

Not sure if this belongs in tech verification or product verification; probably product?

Also, for product to confirm that the sorting issue didn’t come back, we should deploy a new build to query.wikidata.org, but I don’t really want to do that on a Friday.

Arian_Bozorg moved this task from Product Verification to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Aug 15 2023, 1:53 PM
ItamarWMDE changed the task status from Open to Stalled.Aug 21 2023, 3:07 PM
ItamarWMDE moved this task from Tech Verification to Parents/Waiting on the Wikidata Dev Team (Sprint-∞) board.
ItamarWMDE added subscribers: Arian_Bozorg, HasanAkgun_WMDE, guergana.tzatchkova, noarave.

@Arian_Bozorg I think this should also be validated by product after this is deployed to query.wikidata.org as this regression caused a user facing bug before. Other than that the code changes look fine to me.

@noarave, @guergana.tzatchkova, @HasanAkgun_WMDE let's try to meet up and deploy this using these instructions: https://gerrit.wikimedia.org/r/plugins/gitiles/wikidata/query/gui/+/refs/heads/master#deploy

Until then I will mark the task as stalled.

gerritbot added a comment.Aug 23 2023, 9:32 AM

Change 951887 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[wikidata/query/gui@master] Add empty commit to allow query/gui build to run

https://gerrit.wikimedia.org/r/951887

gerritbot added a project: Patch-For-Review.Aug 23 2023, 9:32 AM

Change 951887 merged by jenkins-bot:

[wikidata/query/gui@master] Add empty commit to allow query/gui build to run

https://gerrit.wikimedia.org/r/951887

gerritbot added a comment.Aug 23 2023, 9:40 AM

Change 951888 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder):

[wikidata/query/gui-deploy@production] Merging from d20c6591ab7b311d75bff636e26dc01c6ae88945

https://gerrit.wikimedia.org/r/951888

gerritbot added a comment.Aug 23 2023, 9:44 AM

Change 951888 merged by Guergana Tzatchkova:

[wikidata/query/gui-deploy@production] Merging from d20c6591ab7b311d75bff636e26dc01c6ae88945

https://gerrit.wikimedia.org/r/951888

guergana.tzatchkova moved this task from Parents/Waiting to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Aug 23 2023, 9:46 AM
guergana.tzatchkova moved this task from Tech Verification to Product Verification on the Wikidata Dev Team (Sprint-∞) board.
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2023, 10:11 AM
ItamarWMDE moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Aug 29 2023, 7:19 AM
Lydia_Pintscher closed this task as Resolved.Sep 7 2023, 1:13 PM
Lydia_Pintscher moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
Lydia_Pintscher subscribed.

T327029 is not reoccurring \o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL